Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Handling #22

Open
taymossimc opened this issue Aug 2, 2023 · 2 comments
Open

Image Handling #22

taymossimc opened this issue Aug 2, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@taymossimc
Copy link

taymossimc commented Aug 2, 2023

When teachers/admins create outging pulse messages with images, they are running into problems. If the image tag is using an SRC with a URL that is outside of the Moodle, it works fine. BUT, if the image is "uploaded" to the course, or if they try to use something ilke the course image, for example, it won't load the image. I believe this is because the pluginfile.php script won't serve up an image file if the user is not logged in. An example URL that doesn't work is

https://churchx.ca/pluginfile.php/46340/mod_pulse/pulse_content/0/UILX2010%20ChurchX_ModSquad%20Course.png

Is this a known issue? Is there a workaround?

-Tay Moss
https://churchx.ca

@taymossimc
Copy link
Author

Digging into this a little more... perhaps the method to fix this is calling on webservice/pluginfile.php instead of the other edition of pluginfile.php. This will also require providing a token parameter in the URL and having the webservice enabled.
Thoughts?
-Tay

@stefanscholz
Copy link
Member

Hi @taymossimc ,

Thanks for reporting this issue. Yes, images (files in general) are currently not supported in notifications and would require additional development.

For the next version of Pulse, we're going to consider it as a potential improvement. No other customer so far has requested the feature (if any other customer is reading this, let us know in the comments if it is important for you)

Feel free to create a pull request if you want and we'll review it of course.

Best
Stefan

@stefanscholz stefanscholz added the enhancement New feature or request label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants