Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support scientific notation when attempting to write numeric values within the 8 ASCII character limit #31

Open
jrevels opened this issue May 5, 2020 · 2 comments

Comments

@jrevels
Copy link
Member

jrevels commented May 5, 2020

see

# XXX this is really really hacky and doesn't support use of scientific notation

@OTDE
Copy link
Member

OTDE commented May 21, 2020

Doing some additional looking through the EDF+ annotations spec, it actually doesn't require an 8-character limit for annotation offset/duration floating point representations, which means we don't necessarily need to toggle between supporting and not supporting e-notation in _edf_repr, which should make solving this a tad more straightforward.

@kleinschmidt
Copy link
Member

FWIW, EDFlib (the python library that PyMNE uses for EDF import/export) does not support scientific notation in the physical min/max fields, and uses integers to represent the digital minimum/maximum.

https://gitlab.com/Teuniz/EDFlib-Python/-/blob/master/src/EDFlib/edfwriter.py

It's not clear from the spec whether scientific notation is intended (it just says "8 ASCII characters" and nothing else about the format). So it's possible that other EDF readers wouldn't be able to handle exported EDFs with scientific notation in the physical min/max.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants