Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read headers without reading full file #51

Open
klaff opened this issue Oct 15, 2021 · 1 comment
Open

Cannot read headers without reading full file #51

klaff opened this issue Oct 15, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@klaff
Copy link

klaff commented Oct 15, 2021

Currently, EDF.jl reads the header info and then checks against the file length and corrects the record_count if the file length doesn't match. For performance in certain situations, it would be beneficial to be able to read the header without reading through the rest of the file, or even when the full file length is not available.

@klaff klaff added the enhancement New feature or request label Oct 15, 2021
@palday
Copy link
Member

palday commented Oct 15, 2021

I think we could add a kwarg validate_record_count=true -- really highlights why this exists. There are a number of good and bad reasons why the record count in the header can be incorrect for real data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants