Skip to content
This repository has been archived by the owner on Feb 28, 2023. It is now read-only.

Consider replacing language specific tests for msg formatting with unit test #10

Open
ezmiller opened this issue Feb 5, 2020 · 0 comments

Comments

@ezmiller
Copy link

ezmiller commented Feb 5, 2020

The message format tests in the tests file targeting the message translate function, e.g.:

  • test_icu_plural_ru
  • test_icu_plural_de
  • etc

seem like integration tests targeting PyICU. Do we really need these, or could we just mock MessageFormatter and then check that the locale is passed in as an argument?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant