Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch multiple pages in parallel with full option in findAll #15

Open
2 tasks
edoardocavazza opened this issue Apr 26, 2018 · 1 comment
Open
2 tasks

Comments

@edoardocavazza
Copy link
Member

Calling the findAll Collection's method with the option full: true should fetch necessary data with parallel requests and then join the collections using the correct order.

At the moment, this is impossibile because multiple RelationshipCollection instances use the same internal array instance, so the order of added items depends on the resolution of the fetch call.

This PR temporarily fixes the joinCollection behavior for RelationshipCollection which causes duplicated entries in the collection.

To do:

  • Allow multiple RelationshipCollection instances for the same model
  • Exec multiple pages fetch in parallel
@fquffio
Copy link
Member

fquffio commented Apr 26, 2018

Some initial work on parallel fetching of multiple pages has been done in f92fc46, then reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants