Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions to update the vercel-submodule-workaround #8

Open
trebeljahr opened this issue Mar 18, 2024 · 1 comment
Open

Add instructions to update the vercel-submodule-workaround #8

trebeljahr opened this issue Mar 18, 2024 · 1 comment

Comments

@trebeljahr
Copy link

For me when following the approach as outlined in the Readme it didn't work and I had to update a few things in the setup script.

Specifically, things outlined in this comment:
https://github.com/orgs/vercel/discussions/44#discussioncomment-3391318

I.e.
Instead of:

git fetch --depth=1 origin $COMMIT # fetch only the required version
git checkout $COMMIT # checkout on the right commit

I used:

git fetch origin
git checkout main 
npm install

and I also updated the references for the variables at the beginning of the script accordingly

# github submodule repo address without https:// prefix
SUBMODULE_GITHUB=path to your own, don't forget the .git bit at the end

# .gitmodules submodule path
SUBMODULE_PATH=this can be copied from the gitmodules file
@trebeljahr
Copy link
Author

maybe the readme can be updated to make it clearer that there is extra setup needed and people don't go "ugh, this doesn't work" ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant