From efeb639538f66dadc23f8eccd31aa9bbc147ee17 Mon Sep 17 00:00:00 2001
From: Russell Martin <russell@rjm.li>
Date: Wed, 3 Jan 2024 13:32:14 -0500
Subject: [PATCH] Upgrade `upload-artifact` and `download-artifact` actions to
 v4

---
 .github/workflows/update-binary.yml | 52 ++++++++++++++++-------------
 1 file changed, 28 insertions(+), 24 deletions(-)

diff --git a/.github/workflows/update-binary.yml b/.github/workflows/update-binary.yml
index d919bcd..735b16e 100644
--- a/.github/workflows/update-binary.yml
+++ b/.github/workflows/update-binary.yml
@@ -10,9 +10,9 @@ jobs:
     runs-on: macos-latest
     strategy:
       matrix:
-        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+        python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12" ]
     steps:
-    - name: Set build variables
+    - name: Set Build Variables
       env:
         TAG_NAME: ${{ github.ref }}
       run: |
@@ -21,22 +21,20 @@ jobs:
         export BRIEFCASE_VERSION="${TAG%-*}"
         export BUILD_NUMBER="${TAG#*-}"
 
-        echo "TAG=${TAG}"
-        echo "PYTHON_TAG=${PYTHON_TAG}"
-        echo "BRIEFCASE_VERSION=${BRIEFCASE_VERSION}"
-        echo "BUILD_NUMBER=${BUILD_NUMBER}"
+        echo "TAG=${TAG}" | tee -a $GITHUB_ENV
+        echo "PYTHON_TAG=${PYTHON_TAG}" | tee -a $GITHUB_ENV
+        echo "BRIEFCASE_VERSION=${BRIEFCASE_VERSION}" | tee -a $GITHUB_ENV
+        echo "BUILD_NUMBER=${BUILD_NUMBER}" | tee -a $GITHUB_ENV
 
-        echo "TAG=${TAG}" >> $GITHUB_ENV
-        echo "PYTHON_TAG=${PYTHON_TAG}" >> $GITHUB_ENV
-        echo "BRIEFCASE_VERSION=${BRIEFCASE_VERSION}" >> $GITHUB_ENV
-        echo "BUILD_NUMBER=${BUILD_NUMBER}" >> $GITHUB_ENV
-    - name: Checkout template
-      uses: actions/checkout@v4
-    - name: Set up Python ${{ matrix.python-version }}
+    - name: Checkout Template
+      uses: actions/checkout@v4.1.1
+
+    - name: Setup Python ${{ matrix.python-version }}
       uses: actions/setup-python@v5.0.0
       with:
         python-version: ${{ matrix.python-version }}
-    - name: Install dependencies
+
+    - name: Install Dependencies
       run: |
         python -m pip install --upgrade pip
         if [ "${{ env.BRIEFCASE_VERSION }}" == "dev" ]; then
@@ -45,7 +43,8 @@ jobs:
         else
           python -m pip install briefcase==${{ env.BRIEFCASE_VERSION }}
         fi
-    - name: Generate Xcode app template
+
+    - name: Generate Xcode App Template
       run: |
         # Generate the stub app
         cd stub
@@ -56,10 +55,11 @@ jobs:
         codesign --remove-signature ./build/stub/macos/xcode/build/Release/Stub.app/Contents/MacOS/Stub
         echo "Move the binary into the final location"
         mv ./build/stub/macos/xcode/build/Release/Stub.app/Contents/MacOS/Stub Stub-${{ env.PYTHON_TAG }}
-    - name: Upload Stub artefact
-      uses: actions/upload-artifact@v3
+
+    - name: Upload Stub Artefact
+      uses: actions/upload-artifact@v4.0.0
       with:
-        name: stubs
+        name: stub-${{ matrix.python-version }}
         path: stub/Stub-${{ env.PYTHON_TAG }}
 
   commit-stubs:
@@ -67,7 +67,7 @@ jobs:
     needs: build-stubs
     runs-on: macos-latest
     steps:
-    - name: Set build variables
+    - name: Set Build Variables
       env:
         TAG_NAME: ${{ github.ref }}
       run: |
@@ -93,13 +93,17 @@ jobs:
           echo "TEMPLATE_BRANCH=v${BRIEFCASE_VERSION}"
           echo "TEMPLATE_BRANCH=v${BRIEFCASE_VERSION}" >> $GITHUB_ENV
         fi
-    - name: Checkout template
-      uses: actions/checkout@v4
-    - name: Download Stub artefacts
-      uses: actions/download-artifact@v3
+
+    - name: Checkout Template
+      uses: actions/checkout@v4.1.1
+
+    - name: Download Stub Artefacts
+      uses: actions/download-artifact@v4.1.0
       with:
-        name: stubs
+        pattern: stub-*
         path: stub
+        merge-multiple: true
+
     - name: Commit stubs
       run: |
         git config user.email "brutus@beeware.org"