Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables starting with BEGIN_ should not pass validation #144

Open
macdonst opened this issue Apr 10, 2023 · 2 comments
Open

Comments

@macdonst
Copy link
Member

The CLI/API should not allow users to set environment variables that start with BEGIN_.

@ryanblock
Copy link
Member

ryanblock commented Apr 11, 2023

This should strictly be an API side validation error, although I’m open to relaxing this rule if we feel there is cause to allow it. We will need to have some reserved / internal env var namespace, though!

@macdonst
Copy link
Member Author

@ryanblock yup, I realize the fix will lie in the API code but I wanted to make sure we test it from the CLI to return a good error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants