-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply the Beman Standard rules related to the Beman Library Maturity Model #114
Conversation
97c1f51
to
e3b3ae7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections here. I'm happy to see the progress moving along productively.
We'll still end-up having CI badges - e.g. https://github.com/bemanproject/exemplar/actions/workflows/pre-commit.yml/badge.svg, which is basically the general case. The library status is one-time only (one occurrence). So I think your suggestion don't solve the issue. CC: @bretbrownjr LE. Also, the other proposes solution , this fails the linter (and it will fail anyways when we'll have 5-10 badges :D.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's ready to move forward - approving.
I think that will be a good time to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All concerns addressed.
Thanks for the work @neatudarius .
Last update in this repo after bemanproject/beman#77