Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unconditional constexpr due to trivial union #67

Closed
wusatosi opened this issue Feb 17, 2025 · 2 comments
Closed

Unconditional constexpr due to trivial union #67

wusatosi opened this issue Feb 17, 2025 · 2 comments

Comments

@wusatosi
Copy link
Member

We need to update current implementation to use union as its storage type.

This is because trivial union (P3074) has been voted into C++26 and made unconditional constexpr possible.

@JeffGarland
Copy link
Member

JeffGarland commented Feb 24, 2025

There should be a feature test macro we could check if we wanted to keep the current code and change it if the compiler supports trivial unions. Although maybe that's too complicated?

edit: I see there's another issue to implement -- maybe this is a duplicate?

@wusatosi
Copy link
Member Author

edit: I see there's another issue to implement -- maybe this is a duplicate?

You're right, I will fold this to the other issue.

There should be a feature test macro we could check if we wanted to keep the current code and change it if the compiler supports trivial unions. Although maybe that's too complicated?

It doesn't make sense for us to implement this yet. I don't believe there's any confirmed compiler support yet. Without those we will not be able to test against our implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants