Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal Iterators cannot deal with unweighted networks (without edge attributes)? #283

Open
pauvilasoler opened this issue Oct 15, 2024 · 0 comments

Comments

@pauvilasoler
Copy link

Hello!

Besides the point raised in #279 that the temporal iterators are currently mapping the edge_weights as edge_attr, I guess there is no option (currently) for using unweighted networks when there are no other edge attributes (see below):

image

In the case where the (unweighted network) would have edge attributes, this exceptions would not be raised as (as is currently set up) these edge attributes would be passed as edge_weights (as mentioned in #279, edge_weights can hold multiple features per edge given the mapping to edge_attr of the underlying torch_geometric.data.Data > it would still work in the case with only one (non-weight) edge attribute as well)

However if the underlying temporal network contains neither weights (unweighted) nor edge attributes then check_temporal_consistency() will raise a TypeError.

Other than this, I also agree with #279 that maybe it would be best to rename edge_weights into edge_attr for better consistency with PyG.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant