Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does TSTypeParameter.name need to be all of IdentifierKind types? #939

Open
smurzin opened this issue Jun 8, 2023 · 0 comments
Open

Does TSTypeParameter.name need to be all of IdentifierKind types? #939

smurzin opened this issue Jun 8, 2023 · 0 comments

Comments

@smurzin
Copy link

smurzin commented Jun 8, 2023 •
edited
Loading

It seems that in recent version TSTypeParameter.name has been extended to be string | K.IdentifierKind.

This results in a weird type cycle, where a name can be any identifier including TSTypeParameter again. Causing client code to deal with it somehow. It seems that babel-parser tests do not have any examples of generating anything apart from plain Identifier (or string) for TStypeParameter.name.

Should this be constrained a bit more?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smurzin