We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thank you for sharing this role, it's a real timesaver, though I have a suggestion about default variables.
If I add this role with default variables, it:
mysql_bind_address: "0.0.0.0"
foobar
Though the related variables are mentioned in a basic usage in README, I was still surprised when the role created a repl user.
It is my understanding that the default variables should be used for sharing variables with included and dependent roles, but not as an example usage.
I would like you to consider a bit more sensitive default behaviour, for example:
127.0.0.1
mysql_root_db_pass
The omitted variables should be either explained in documentation or commented out in defaults/main.yml as an example usage.
defaults/main.yml
I'd be happy to send a PR if you agree with this proposal.
The text was updated successfully, but these errors were encountered:
Hi Jnv,
Sounds reasonable, if you can send in a PR it would be great.. else i would update the roles in shortly.
Sorry, something went wrong.
No branches or pull requests
Thank you for sharing this role, it's a real timesaver, though I have a suggestion about default variables.
If I add this role with default variables, it:
mysql_bind_address: "0.0.0.0"
)foobar
to the root userfoobar
Though the related variables are mentioned in a basic usage in README, I was still surprised when the role created a repl user.
It is my understanding that the default variables should be used for sharing variables with included and dependent roles, but not as an example usage.
I would like you to consider a bit more sensitive default behaviour, for example:
127.0.0.1
by defaultmysql_root_db_pass
could be either mandatory, or related tasks would be skipped when the password is missingThe omitted variables should be either explained in documentation or commented out in
defaults/main.yml
as an example usage.I'd be happy to send a PR if you agree with this proposal.
The text was updated successfully, but these errors were encountered: