perform_limit and perform_throttle don't work both

[doits]

Can it be that there is a bug when perform_limit and perform_throttle are both specified so that perform_throttle is ignored? Isn't this "next" at line 153 skipping throttling if the limit isn't reached, which means you cannot have both?

good_job/lib/good_job/active_job_extensions/concurrency.rb

Lines 146 to 156 in 59c3300

	if limit
	allowed_active_job_ids = GoodJob::Job.unfinished.where(concurrency_key: key)
	.advisory_locked
	.order(Arel.sql("COALESCE(performed_at, scheduled_at, created_at) ASC"))
	.limit(limit).pluck(:active_job_id)
	# The current job has already been locked and will appear in the previous query
	exceeded = :limit unless allowed_active_job_ids.include?(job.job_id)
	next
	end
	if throttle

Shouldn't it only skip throttling if it is exceeded already?

   unless allowed_active_job_ids.include?(job.job_id)
     exceeded = :limit  
     next 
  end

Originally posted by @doits in #1353 (comment)

[doits]

I think this bug was introduced by refactoring in #1439

[bensheldon]

Thanks for opening this issue. I'm staring at it for a couple minutes now and I think you're correct that the current logic is wrong. We want to next/jump only if the job should be rescheduled, and continue testing the following conditions otherwise.

Is this a PR you'd be comfortable making?

[doits]

sure, I'll add a spec do a PR

[doits]

Please see #1470 for the PR

[bensheldon]

Thank you! This fix has been released: https://github.com/bensheldon/good_job/releases/tag/v4.2.0