-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perform_limit
and perform_throttle
don't work both
#1469
Comments
I think this bug was introduced by refactoring in #1439 |
Thanks for opening this issue. I'm staring at it for a couple minutes now and I think you're correct that the current logic is wrong. We want to Is this a PR you'd be comfortable making? |
sure, I'll add a spec do a PR |
Please see #1470 for the PR |
Thank you! This fix has been released: https://github.com/bensheldon/good_job/releases/tag/v4.2.0 |
Can it be that there is a bug when
perform_limit
andperform_throttle
are both specified so thatperform_throttle
is ignored? Isn't this "next" at line 153 skipping throttling if the limit isn't reached, which means you cannot have both?good_job/lib/good_job/active_job_extensions/concurrency.rb
Lines 146 to 156 in 59c3300
Shouldn't it only skip throttling if it is exceeded already?
Originally posted by @doits in #1353 (comment)
The text was updated successfully, but these errors were encountered: