Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can you add a lat/long location method? #12

Open
ilyinss opened this issue Mar 6, 2023 · 4 comments
Open

can you add a lat/long location method? #12

ilyinss opened this issue Mar 6, 2023 · 4 comments

Comments

@ilyinss
Copy link

ilyinss commented Mar 6, 2023

Hello!
in your code i find this one:

  # Latitude is dependent on location
  suppressMessages(
    capture.output(
      gocodeData <-  tibble(singlelineaddress = location) %>%
                     geocode(address=singlelineaddress,method = 'arcgis')
    )
  )

  lat <- gocodeData %>% .[["lat"]]
  # longitude for line3_text
  lon_map <-gocodeData %>%  .[["long"]]

its means that i need to put in your method address like string> That address you put in other function (geocode) and get lat/long on this.

its very simple, but not very flexible. i cant find lat long for some cities in Armenia ((
its been very nice of you if you add this one to your library.

P.S. thank you for your library! With your library i want to create and print cards and congratulate our colleagaues with 8 march day )
when i'm print it - i take a foto and send you ))

In russian i may say it like this: Ребята, вы супер-крутые! Громадное спасибо вам за то, что вы написали. Это потрясающе и восхитительно!

thanks a lot!

@benyamindsmith
Copy link
Owner

@ilyinss I'm really happy that you're enjoying the package! Please do send me the picture when you print it!

As far as the address not being flexible, I found that if you are really specific with your location the result will be provided.

So for your case I would write <city>,<province>, Armenia and that should give you the result that you want.

Let me know if this is helpful!

@ilyinss
Copy link
Author

ilyinss commented Mar 6, 2023 via email

@benyamindsmith
Copy link
Owner

@ilyinss I see.

Thats definitely a good idea. Maybe I should make a separate function which allows for a specific lon/lat coordinate to be specified.

As far as the other ideas are concerned:

  1. More colors are definitely invited. If you have a specific set of colors in mind let me know and I can make them. Alternatively I could create a seperate function which allows for users to specify primary and secondary colors.

  2. More text fonts are also a good idea. Maybe it could also be added in this new function.

  3. There is no end to the number of lines that could be added so I don't know if it makes sense to add more lines.

Thank you so much for using the package! When I get a chance I will try to add some more features. Feel free to make submit a PR if you have a feature that you want to add!

@ilyinss
Copy link
Author

ilyinss commented Mar 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants