Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call json files from package, not repository #4

Open
laresbernardo opened this issue Jan 20, 2023 · 6 comments
Open

Call json files from package, not repository #4

laresbernardo opened this issue Jan 20, 2023 · 6 comments
Labels
enhancement New feature or request Under Review

Comments

@laresbernardo
Copy link

Ideally, load the json files from the data directory instead of downloading from the repository. That way users don't have to deal with internet connection to use your package. Also, try to follow data usage best practices in an R package.

@benyamindsmith
Copy link
Owner

@laresbernardo Thank you for all the issues you posted so far! They are all really helpful!

Loading the files from the data directory instead of downloading from the repository would be much better. However it doesn't solve the internet connection problem fully as it is the geocoding is done with tidygeocoder and uses the ArcGIS API.

I'll still look into fixing this issue.

@benyamindsmith
Copy link
Owner

@laresbernardo Check out this fix

@benyamindsmith benyamindsmith added enhancement New feature or request Under Review labels Jan 24, 2023
@laresbernardo
Copy link
Author

Oops:

Error: Cannot open "data/constellations.lines.json"; The file doesn't seem to exist.

@laresbernardo
Copy link
Author

Try something like this instead: file <- system.file("inst/docs", "yourfile", package = "starBliss")

@benyamindsmith
Copy link
Owner

@laresbernardo check this

@benyamindsmith
Copy link
Owner

@laresbernardo let me know if this is ok. Otherwise I will be closing this issue soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Under Review
Projects
None yet
Development

No branches or pull requests

2 participants