let extract_source
= builddir
when more than one folders being extracted
#138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Sometimes, a tar ball does not retain the parent directory. e.g. After type
tar -xvf abc.tar.gz
, there are some sub directories under thebuilddir
likesrc
,doc
... instead of theabc
folder.The original code chooses the latest created folder after extraction to be the working directory for the building stage. I guess it makes more sense if we could return
builddir
to handle the above case (when more than one folders are extracted).The new code return
Dir.pwd
directly, since already the working dir has been changed tobuilddir
. And I make no changes to the tests since the change itself didn't break the test.Regards
Yichao