From 2b34bf975c6cd62953a6a06ca1a99fb03da50e61 Mon Sep 17 00:00:00 2001 From: Bernd Finger Date: Fri, 12 Jan 2024 17:08:11 +0100 Subject: [PATCH 1/2] collection: Rearrange comments in .ansible-lint Fixes #593 for the collection's .ansible-lint file Signed-off-by: Bernd Finger --- .ansible-lint | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.ansible-lint b/.ansible-lint index 88bbb5659..fc315df23 100644 --- a/.ansible-lint +++ b/.ansible-lint @@ -21,12 +21,16 @@ exclude_paths: #- roles/sap_swpm - roles/sap_vm_preconfigure - tests/ - enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: - experimental - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] From 2ce2a04ff9a87803be935971c0472e5ac1075056 Mon Sep 17 00:00:00 2001 From: Bernd Finger Date: Fri, 12 Jan 2024 17:15:28 +0100 Subject: [PATCH 2/2] all roles: Adapt .ansible-lint So the exclude_paths, enable_list, and skip_list are identical to those in the collection's .ansible-lint file. Solves issue #593. Signed-off-by: Bernd Finger --- roles/sap_anydb_install_oracle/.ansible-lint | 15 ++++++++++++--- roles/sap_general_preconfigure/.ansible-lint | 14 ++++++++++---- roles/sap_ha_install_hana_hsr/.ansible-lint | 14 ++++++++++---- roles/sap_ha_pacemaker_cluster/.ansible-lint | 14 ++++++++++---- roles/sap_hana_install/.ansible-lint | 14 ++++++++++---- roles/sap_hana_preconfigure/.ansible-lint | 14 ++++++++++---- roles/sap_hostagent/.ansible-lint | 14 ++++++++++---- .../.ansible-lint | 14 ++++++++++---- roles/sap_install_media_detect/.ansible-lint | 14 ++++++++++---- roles/sap_maintain_etc_hosts/.ansible-lint | 14 ++++++++++---- roles/sap_netweaver_preconfigure/.ansible-lint | 14 ++++++++++---- roles/sap_storage_setup/.ansible-lint | 14 ++++++++++---- roles/sap_swpm/.ansible-lint | 14 ++++++++++---- roles/sap_vm_preconfigure/.ansible-lint | 15 ++++++++++++--- 14 files changed, 144 insertions(+), 54 deletions(-) diff --git a/roles/sap_anydb_install_oracle/.ansible-lint b/roles/sap_anydb_install_oracle/.ansible-lint index 63122b8f9..8a5df4d43 100644 --- a/roles/sap_anydb_install_oracle/.ansible-lint +++ b/roles/sap_anydb_install_oracle/.ansible-lint @@ -1,7 +1,16 @@ --- +exclude_paths: + - tests/ enable_list: - yaml skip_list: - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_general_preconfigure/.ansible-lint b/roles/sap_general_preconfigure/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_general_preconfigure/.ansible-lint +++ b/roles/sap_general_preconfigure/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_ha_install_hana_hsr/.ansible-lint b/roles/sap_ha_install_hana_hsr/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_ha_install_hana_hsr/.ansible-lint +++ b/roles/sap_ha_install_hana_hsr/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_ha_pacemaker_cluster/.ansible-lint b/roles/sap_ha_pacemaker_cluster/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_ha_pacemaker_cluster/.ansible-lint +++ b/roles/sap_ha_pacemaker_cluster/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_hana_install/.ansible-lint b/roles/sap_hana_install/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_hana_install/.ansible-lint +++ b/roles/sap_hana_install/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_hana_preconfigure/.ansible-lint b/roles/sap_hana_preconfigure/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_hana_preconfigure/.ansible-lint +++ b/roles/sap_hana_preconfigure/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_hostagent/.ansible-lint b/roles/sap_hostagent/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_hostagent/.ansible-lint +++ b/roles/sap_hostagent/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_hypervisor_node_preconfigure/.ansible-lint b/roles/sap_hypervisor_node_preconfigure/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_hypervisor_node_preconfigure/.ansible-lint +++ b/roles/sap_hypervisor_node_preconfigure/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_install_media_detect/.ansible-lint b/roles/sap_install_media_detect/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_install_media_detect/.ansible-lint +++ b/roles/sap_install_media_detect/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_maintain_etc_hosts/.ansible-lint b/roles/sap_maintain_etc_hosts/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_maintain_etc_hosts/.ansible-lint +++ b/roles/sap_maintain_etc_hosts/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_netweaver_preconfigure/.ansible-lint b/roles/sap_netweaver_preconfigure/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_netweaver_preconfigure/.ansible-lint +++ b/roles/sap_netweaver_preconfigure/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_storage_setup/.ansible-lint b/roles/sap_storage_setup/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_storage_setup/.ansible-lint +++ b/roles/sap_storage_setup/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_swpm/.ansible-lint b/roles/sap_swpm/.ansible-lint index 1405704bf..8a5df4d43 100644 --- a/roles/sap_swpm/.ansible-lint +++ b/roles/sap_swpm/.ansible-lint @@ -4,7 +4,13 @@ exclude_paths: enable_list: - yaml skip_list: - - meta-runtime[unsupported-version] # We don't want to enforce new Ansible versions for Galaxy - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template] diff --git a/roles/sap_vm_preconfigure/.ansible-lint b/roles/sap_vm_preconfigure/.ansible-lint index 63122b8f9..8a5df4d43 100644 --- a/roles/sap_vm_preconfigure/.ansible-lint +++ b/roles/sap_vm_preconfigure/.ansible-lint @@ -1,7 +1,16 @@ --- +exclude_paths: + - tests/ enable_list: - yaml skip_list: - - ignore-errors # We use ignore_errors for all the assert tasks, which should be acceptable - - schema # We want to allow single digit version numbers in a role's meta/main.yml file. This is allowed as per https://galaxy.ansible.com/docs/contributing/creating_role.html and https://galaxy.ansible.com/api/v1/platforms/?page=6. - - name[template] # Allow templating inside name. During dev and qa, it should be possible to identify cases where it doesn't work + # We don't want to enforce new Ansible versions for Galaxy: + - meta-runtime[unsupported-version] + # We do not want to use checks which are marked as experimental: + - experimental + # We use ignore_errors for all the assert tasks, which should be acceptable: + - ignore-errors + # We want to allow single digit version numbers in a role's meta/main.yml file: + - schema + # Allow templating inside name because it creates more detailed output: + - name[template]