Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested modules should include "jdk.localedata" when required #108

Open
hansi-b opened this issue Nov 29, 2021 · 1 comment
Open

Suggested modules should include "jdk.localedata" when required #108

hansi-b opened this issue Nov 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@hansi-b
Copy link

hansi-b commented Nov 29, 2021

It seems the suggested modules do not include jdk.localedata when a non-US locale is used in the code.

The following example uses a German locale to correctly parse decimal numbers:

https://github.com/hansi-b/JpackageLocaleTest/blob/master/app/src/main/java/loc_test/App.java

If you run the suggestModules task for that project, it only lists jdk.base (and the resulting jpackaged application prints the wrong values, using the US locale). If you explicitly add jdk.localedata via build.gradle, it works.

This can introduce puzzling behaviour in an application (see https://stackoverflow.com/questions/70009017); might it be possible to have a heuristic to suggest jdk.localedata when a non-US locale is used?

@hansi-b hansi-b changed the title Suggested modules should detect required "jdk.localedata" Suggested modules should include "jdk.localedata" when required Nov 30, 2021
@hakanai
Copy link
Collaborator

hakanai commented Jan 18, 2023

Tricky... but I sort of agree.

@hakanai hakanai added the enhancement New feature or request label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants