Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Additional Virtual Table Functionality in apsw 3.41.0.0 #344

Open
1 of 3 tasks
cancan101 opened this issue Mar 20, 2023 · 9 comments
Open
1 of 3 tasks

Support Additional Virtual Table Functionality in apsw 3.41.0.0 #344

cancan101 opened this issue Mar 20, 2023 · 9 comments

Comments

@cancan101
Copy link
Collaborator

cancan101 commented Mar 20, 2023

See release notes, specifically:

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@betodealmeida
Copy link
Owner

Yeah! I started working on this, but had some problems compiling from source. With the new release I should be able to jus use the wheel. Will finish the branch.

@gfieremans
Copy link

@betodealmeida - see discussion in rogerbinns/apsw#428. You need to increment the value of the argvIndex in your function BestIndexObject():

for i, constraint in enumerate(constraints_used): if isinstance(constraint, tuple): index_info.set_aConstraintUsage_argvIndex(i, constraint[0]**+1**) index_info.set_aConstraintUsage_omit(i, constraint[1])

@betodealmeida
Copy link
Owner

Ah, thanks, I'll fix it!

@gfieremans
Copy link

By the way - I applied your bestindex branch to 1.2.0 and built it and everything is working great. Also was able to get the multiselect constraintargs in the Filter() method. if you're interested I can share my changes for that - although I wonder whether that's not too specific to my use case.

@betodealmeida
Copy link
Owner

Also was able to get the multiselect constraintargs in the Filter() method.

You mean supporting IN statements? That would be great!

@gfieremans
Copy link

Yes, that's why I went with the BestIndexObject you provided. Shall I checkout a branch off the bestindex branch?

@betodealmeida
Copy link
Owner

The best index branch has been merged in master, so you can just use master.

@betodealmeida
Copy link
Owner

(I should start deleting branches.)

@ananbas
Copy link

ananbas commented Feb 15, 2024

hi, can you elaborate how to support IN statements?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants