Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top tool bar - Done Button overlaps when moving element during text edit #17

Open
BillCarsonFr opened this issue Aug 4, 2017 · 3 comments

Comments

@BillCarsonFr
Copy link

Hello,

I just noticed that if you move an element (e.g sticker) while editing a text, when the you finish the move gesture both toolbar (top) and done button are displayed on screen.

Not sure if best way to stop it is to detect that there is a textView that is firstResponder in #moveView (state == ended) and then keep tool bars hidden, or to force end edit when a move is detected (on element that is not current text).

BTW, great work 👍

@jeyremy
Copy link

jeyremy commented Nov 15, 2017

Hi, i got this one too ^^

Great great work.

@jonchui
Copy link

jonchui commented Jul 27, 2018

UPDATE: of course @jeyremy you already pushed the PR!! #19 thanks!

@BillCarsonFr or @jeyremy , did either of you guys fix this? If so, can you push a PR?

@jeyremy
Copy link

jeyremy commented Jul 27, 2018

@jonchui you are welcome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants