Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adjust rf and LTV on polygon #613

Merged
merged 11 commits into from
Feb 20, 2025
Merged

feat: adjust rf and LTV on polygon #613

merged 11 commits into from
Feb 20, 2025

Conversation

Rozengarden
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

🌈Test Results Compiling 320 files with Solc 0.8.22 Solc 0.8.22 finished in 151.19s Compiler run successful with warnings: Warning (2018): Function state mutability can be restricted to pure --> lib/aave-helpers/src/ProtocolV2TestBase.sol:664:3: | 664 | function _logReserveConfig(ReserveConfig memory config) internal view { | ^ (Relevant source part starts here and spans across multiple lines).

2025-02-20T12:16:13.252548Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^1.1.17", "diff-snapshots", "./reports/AaveV2Polygon_AdjustRiskParametersForAaveV2AndV3OnPolygon_20250210_before.json", "./reports/AaveV2Polygon_AdjustRiskParametersForAaveV2AndV3OnPolygon_20250210_after.json", "-o", "./diffs/AaveV2Polygon_AdjustRiskParametersForAaveV2AndV3OnPolygon_20250210_before_AaveV2Polygon_AdjustRiskParametersForAaveV2AndV3OnPolygon_20250210_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/[email protected]\n"

Ran 1 test for src/20250210_Multi_AdjustRiskParametersForAaveV2AndV3OnPolygon/AaveV2Polygon_AdjustRiskParametersForAaveV2AndV3OnPolygon_20250210.t.sol:AaveV2Polygon_AdjustRiskParametersForAaveV2AndV3OnPolygon_20250210_Test
[PASS] test_defaultProposalExecution() (gas: 24453785)
Logs:
E2E: Collateral WBTC, TestAsset DAI
SUPPLY: WBTC, Amount: 285137439
SUPPLY: DAI, Amount: 2704504955695312062763
WITHDRAW: DAI, Amount: 1352252477847656031381
WITHDRAW: DAI, Amount: 1352252477847656031382
BORROW: DAI, Amount 2704504955695312062763, Stable: false
REPAY: DAI, Amount: 2704504955695312062763
E2E: Collateral WBTC, TestAsset USDC
SUPPLY: WBTC, Amount: 285137439
SUPPLY: USDC, Amount: 2705396849
WITHDRAW: USDC, Amount: 1352698424
WITHDRAW: USDC, Amount: 1352698425
BORROW: USDC, Amount 2705396849, Stable: false
REPAY: USDC, Amount: 2705396849
E2E: Collateral WBTC, TestAsset USDT
SUPPLY: WBTC, Amount: 285137439
SUPPLY: USDT, Amount: 2705116248
WITHDRAW: USDT, Amount: 1352558124
WITHDRAW: USDT, Amount: 1352558124
BORROW: USDT, Amount 2705116248, Stable: false
REPAY: USDT, Amount: 2705116248
E2E: Collateral WBTC, TestAsset WBTC
SUPPLY: WBTC, Amount: 285137439
SUPPLY: WBTC, Amount: 2851374
WITHDRAW: WBTC, Amount: 1425687
WITHDRAW: WBTC, Amount: 1425688
BORROW: WBTC, Amount 2851374, Stable: false
REPAY: WBTC, Amount: 2851374
E2E: Collateral WBTC, TestAsset WETH
SUPPLY: WBTC, Amount: 285137439
SUPPLY: WETH, Amount: 1000000000000000000
WITHDRAW: WETH, Amount: 500000000000000000
WITHDRAW: WETH, Amount: 500000000000000000
BORROW: WETH, Amount 1000000000000000000, Stable: false
REPAY: WETH, Amount: 1000000000000000000
E2E: Collateral WBTC, TestAsset WPOL
SUPPLY: WBTC, Amount: 285137439
SUPPLY: WPOL, Amount: 8536067966345125062295
WITHDRAW: WPOL, Amount: 4268033983172562531147
WITHDRAW: WPOL, Amount: 4268033983172562531148
BORROW: WPOL, Amount 8536067966345125062295, Stable: false
REPAY: WPOL, Amount: 8536067966345125062295

Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 16.27s (15.77s CPU time)

Ran 1 test suite in 16.28s (16.27s CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)
No files changed, compilation skipped

Ran 1 test for src/20250210_Multi_AdjustRiskParametersForAaveV2AndV3OnPolygon/AaveV3Polygon_AdjustRiskParametersForAaveV2AndV3OnPolygon_20250210.t.sol:AaveV3Polygon_AdjustRiskParametersForAaveV2AndV3OnPolygon_20250210_Test
[PASS] test_defaultProposalExecution() (gas: 55352946)
Logs:
0x8f3Cf7ad23Cd3CaDbD9735AFf958023239c6A063
0x53E0bca35eC356BD5ddDFebbD1Fc0fD03FaBad39
0x2791Bca1f2de4661ED88A30C99A7a9449Aa84174
0x1BFD67037B42Cf73acF2047067bd4F2C47D9BfD6
0x7ceB23fD6bC0adD59E62ac25578270cFf1b9f619
0xc2132D05D31c914a87C6611C10748AEb04B58e8F
0x0d500B1d8E8eF31E21C99d1Db9A6444d3ADf1270
0x172370d5Cd63279eFa6d502DAB29171933a610AF
0x0b3F868E0BE5597D5DB7fEB59E1CADBb0fdDa50a
0x385Eeac5cB85A38A9a07A70c73e0a3271CfB54A7
0x9a71012B13CA4d3D0Cdc72A177DF3ef03b0E76A3
0x85955046DF4668e1DD369D2DE9f3AEB98DD2A369
0xE111178A87A3BFf0c8d18DECBa5798827539Ae99
0x4e3Decbb3645551B8A19f0eA1678079FCB33fB4c
0xE0B52e49357Fd4DAf2c15e02058DCE6BC0057db4
0xa3Fa99A148fA48D14Ed51d610c367C61876997F1
0xfa68FB4628DFF1028CFEc22b4162FCcd0d45efb6
0x03b54A6e9a984069379fae1a4fC4dBAE93B3bCCD
0x3c499c542cEF5E3811e1192ce70d8cC03d5c3359
E2E: Collateral LINK, TestAsset DAI
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: DAI, Amount: 999764025697014733612
WITHDRAW: DAI, Amount: 499882012848507366806
WITHDRAW: DAI, Amount: 499882012848507366806
BORROW: DAI, Amount 999764025697014733612
REPAY: DAI, Amount: 999764025697014733612
E2E: Collateral LINK, TestAsset LINK
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: LINK, Amount: 53113941820056782819
WITHDRAW: LINK, Amount: 26556970910028391409
WITHDRAW: LINK, Amount: 26556970910028391410
BORROW: LINK, Amount 53113941820056782819
REPAY: LINK, Amount: 53113941820056782819
E2E: Collateral LINK, TestAsset USDC
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: USDC, Amount: 1000093728
WITHDRAW: USDC, Amount: 500046864
WITHDRAW: USDC, Amount: 500046865
BORROW: USDC, Amount 1000093728
REPAY: USDC, Amount: 1000093728
E2E: Collateral LINK, TestAsset WBTC
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: WBTC, Amount: 1049313
WITHDRAW: WBTC, Amount: 524656
WITHDRAW: WBTC, Amount: 524656
BORROW: WBTC, Amount 1049313
REPAY: WBTC, Amount: 1049313
E2E: Collateral LINK, TestAsset WETH
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: WETH, Amount: 369666183673153285
WITHDRAW: WETH, Amount: 184833091836576642
WITHDRAW: WETH, Amount: 184833091836576643
BORROW: WETH, Amount 369666183673153285
REPAY: WETH, Amount: 369666183673153285
E2E: Collateral LINK, TestAsset USDT
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: USDT, Amount: 999990000
WITHDRAW: USDT, Amount: 499995000
WITHDRAW: USDT, Amount: 499995000
BORROW: USDT, Amount 999990000
REPAY: USDT, Amount: 999990000
E2E: Collateral LINK, TestAsset AAVE
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: AAVE, Amount: 3814904188348459238
WITHDRAW: AAVE, Amount: 1907452094174229619
WITHDRAW: AAVE, Amount: 1907452094174229618
E2E: Collateral LINK, TestAsset WPOL
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: WPOL, Amount: 3176027950824542908439
WITHDRAW: WPOL, Amount: 1588013975412271454219
WITHDRAW: WPOL, Amount: 1588013975412271454219
BORROW: WPOL, Amount 3176027950824542908439
REPAY: WPOL, Amount: 3176027950824542908439
E2E: TestAsset CRV SKIPPED
E2E: TestAsset SUSHI SKIPPED
E2E: Collateral LINK, TestAsset GHST
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: GHST, Amount: 1825353999115141395388
WITHDRAW: GHST, Amount: 912676999557570697694
WITHDRAW: GHST, Amount: 912676999557570697695
E2E: TestAsset BAL SKIPPED
E2E: TestAsset DPI SKIPPED
E2E: Collateral LINK, TestAsset EURS
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: EURS, Amount: 95410
WITHDRAW: EURS, Amount: 47705
WITHDRAW: EURS, Amount: 47706
BORROW: EURS, Amount 95410
REPAY: EURS, Amount: 95410
E2E: TestAsset jEUR SKIPPED
E2E: TestAsset EURA SKIPPED
E2E: TestAsset miMATIC SKIPPED
E2E: TestAsset stMATIC SKIPPED
E2E: Collateral LINK, TestAsset MaticX
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: MaticX, Amount: 2772168756327475186317
WITHDRAW: MaticX, Amount: 1386084378163737593158
WITHDRAW: MaticX, Amount: 1386084378163737593160
Skip Borrowing: MaticX, borrow cap fully utilized
E2E: Collateral LINK, TestAsset wstETH
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: wstETH, Amount: 309548886754973946
WITHDRAW: wstETH, Amount: 154774443377486973
WITHDRAW: wstETH, Amount: 154774443377486973
BORROW: wstETH, Amount 309548886754973946
REPAY: wstETH, Amount: 309548886754973946
E2E: Collateral LINK, TestAsset USDC
SUPPLY: LINK, Amount: 5311394182005678281921
SUPPLY: USDC, Amount: 1000093728
WITHDRAW: USDC, Amount: 500046864
WITHDRAW: USDC, Amount: 500046865
BORROW: USDC, Amount 1000093728
REPAY: USDC, Amount: 1000093728

Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 2.18s (2.00s CPU time)

Ran 1 test suite in 2.19s (2.18s CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)

brotherlymite
brotherlymite reviewed Feb 19, 2025
View reviewed changes
lib/aave-helpers Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the lib is not updated to the latest, so the tests still fail

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very weird, I did forge update lib/aave-helpers.
In the last commit (ddab079) I just ran forge install https://github.com/bgd-labs/aave-helpers. Maybe a bit hardcore but then it should works

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you told me in PM, with branch=main it worked like a charm.
Should be good now @brotherlymite

Rozengarden and others added 4 commits February 20, 2025 12:53
@Rozengarden @brotherlymite
Update src/20250210_Multi_AdjustRiskParametersForAaveV2AndV3OnPolygon…
85768cf 
…/AdjustRiskParametersForAaveV2AndV3OnPolygon.md

Co-authored-by: Harsh Pandey <[email protected]>
@Rozengarden @brotherlymite
Update src/20250210_Multi_AdjustRiskParametersForAaveV2AndV3OnPolygon…
8a9f16e 
…/AdjustRiskParametersForAaveV2AndV3OnPolygon.md

Co-authored-by: Harsh Pandey <[email protected]>
@Rozengarden @brotherlymite
Update src/20250210_Multi_AdjustRiskParametersForAaveV2AndV3OnPolygon…
2c58b3b 
…/AdjustRiskParametersForAaveV2AndV3OnPolygon.md

Co-authored-by: Harsh Pandey <[email protected]>
@Rozengarden
Update AdjustRiskParametersForAaveV2AndV3OnPolygon.md
1a1b77d
@brotherlymite brotherlymite merged commit 9300a9a into bgd-labs:main Feb 20, 2025
4 checks passed
LucasWongC pushed a commit to TokenLogic-com-au/aave-proposals-v3 that referenced this pull request Feb 26, 2025
@Rozengarden @MartinGbz
@brotherlymite @LucasWongC
feat: adjust rf and LTV on polygon (bgd-labs#613)
e574903 
* feat: adjust rf and LTV on polygon

* feat: set ltv to  0 instead of freeze

* ⬆️ bump aave-helpers

* forge install: aave-helpers

v3.0.0

* ➖ remove aave-helpers

* forge install: aave-helpers

v3.0.0

* ⬆️ bump aave-helpers to last commit

* Update src/20250210_Multi_AdjustRiskParametersForAaveV2AndV3OnPolygon/AdjustRiskParametersForAaveV2AndV3OnPolygon.md

Co-authored-by: Harsh Pandey <[email protected]>

* Update src/20250210_Multi_AdjustRiskParametersForAaveV2AndV3OnPolygon/AdjustRiskParametersForAaveV2AndV3OnPolygon.md

Co-authored-by: Harsh Pandey <[email protected]>

* Update src/20250210_Multi_AdjustRiskParametersForAaveV2AndV3OnPolygon/AdjustRiskParametersForAaveV2AndV3OnPolygon.md

Co-authored-by: Harsh Pandey <[email protected]>

* Update AdjustRiskParametersForAaveV2AndV3OnPolygon.md

---------

Co-authored-by: MartinGbz <[email protected]>
Co-authored-by: Harsh Pandey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinGbz MartinGbz MartinGbz left review comments

@brotherlymite brotherlymite brotherlymite approved these changes

@pavelvm5 pavelvm5 pavelvm5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rozengarden @brotherlymite @MartinGbz @pavelvm5