onboard wrsETH on Base - Review #632
Conversation
marczeller
changed the title
🌈Test ResultsCompiling 307 files with Solc 0.8.22 Solc 0.8.22 finished in 155.06s Compiler run successful! 2025-02-26T12:53:10.081278Z ERROR cheatcodes: non-empty stderr input=["npx", "@bgd-labs/aave-cli@^1.1.17", "diff-snapshots", "./reports/AaveV3Base_WrsETHBaseOnboarding_20250226_before.json", "./reports/AaveV3Base_WrsETHBaseOnboarding_20250226_after.json", "-o", "./diffs/AaveV3Base_WrsETHBaseOnboarding_20250226_before_AaveV3Base_WrsETHBaseOnboarding_20250226_after.md"] stderr="npm warn exec The following package was not found and will be installed: @bgd-labs/[email protected]\nerror: unrecognized subcommand 'source'\n\n tip: some similar subcommands exist: 'nonce', 'gas-price', 's', 'storage', 'sr', 'src'\n\nUsage: cast [OPTIONS] \n\nFor more information, try '--help'.\nerror: unrecognized subcommand 'source'\n\n tip: some similar subcommands exist: 'nonce', 'gas-price', 's', 'storage', 'sr', 'src'\n\nUsage: cast [OPTIONS] \n\nFor more information, try '--help'.\nnode:internal/errors:984\n const err = new Error(message);\n ^\n\nError: Command failed: cast source --chain 8453 -d /tmp/8453_0x98F409Fc4A42F34AE3c326c7f48ED01ae8cAeC69 0x98F409Fc4A42F34AE3c326c7f48ED01ae8cAeC69 --etherscan-api-key undefined && forge fmt /tmp/8453_0x98F409Fc4A42F34AE3c326c7f48ED01ae8cAeC69\nerror: unrecognized subcommand 'source'\n\n tip: some similar subcommands exist: 'nonce', 'gas-price', 's', 'storage', 'sr', 'src'\n\nUsage: cast [OPTIONS] \n\nFor more information, try '--help'.\n\n at genericNodeError (node:internal/errors:984:15)\n at wrappedFn (node:internal/errors:538:14)\n at checkExecSyncError (node:child_process:891:11)\n at execSync (node:child_process:963:15)\n at downloadContract (file:///home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/@bgd-labs/aave-cli/dist/cli.js:862:3)\n at diffSlot (file:///home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/@bgd-labs/aave-cli/dist/cli.js:914:16)\n at file:///home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/@bgd-labs/aave-cli/dist/cli.js:937:11\n at Array.map ()\n at diffRawStorage (file:///home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/@bgd-labs/aave-cli/dist/cli.js:929:22)\n at diffReports (file:///home/runner/.npm/_npx/bde9fde5cd15b9c3/node_modules/@bgd-labs/aave-cli/dist/cli.js:1084:5) {\n status: 2,\n signal: null,\n output: [\n null,\n Buffer(0) [Uint8Array] [],\n Buffer(200) [Uint8Array] [\n 101, 114, 114, 111, 114, 58, 32, 117, 110, 114, 101, 99,\n 111, 103, 110, 105, 122, 101, 100, 32, 115, 117, 98, 99,\n 111, 109, 109, 97, 110, 100, 32, 39, 115, 111, 117, 114,\n 99, 101, 39, 10, 10, 32, 32, 116, 105, 112, 58, 32,\n 115, 111, 109, 101, 32, 115, 105, 109, 105, 108, 97, 114,\n 32, 115, 117, 98, 99, 111, 109, 109, 97, 110, 100, 115,\n 32, 101, 120, 105, 115, 116, 58, 32, 39, 110, 111, 110,\n 99, 101, 39, 44, 32, 39, 103, 97, 115, 45, 112, 114,\n 105, 99, 101, 39,\n ... 100 more items\n ]\n ],\n pid: 4127,\n stdout: Buffer(0) [Uint8Array] [],\n stderr: Buffer(200) [Uint8Array] [\n 101, 114, 114, 111, 114, 58, 32, 117, 110, 114, 101, 99,\n 111, 103, 110, 105, 122, 101, 100, 32, 115, 117, 98, 99,\n 111, 109, 109, 97, 110, 100, 32, 39, 115, 111, 117, 114,\n 99, 101, 39, 10, 10, 32, 32, 116, 105, 112, 58, 32,\n 115, 111, 109, 101, 32, 115, 105, 109, 105, 108, 97, 114,\n 32, 115, 117, 98, 99, 111, 109, 109, 97, 110, 100, 115,\n 32, 101, 120, 105, 115, 116, 58, 32, 39, 110, 111, 110,\n 99, 101, 39, 44, 32, 39, 103, 97, 115, 45, 112, 114,\n 105, 99, 101, 39,\n ... 100 more items\n ]\n}\n\nNode.js v20.18.3\n"Ran 3 tests for src/20250226_AaveV3Base_WrsETHBaseOnboarding/AaveV3Base_WrsETHBaseOnboarding_20250226.t.sol:AaveV3Base_WrsETHBaseOnboarding_20250226_Test [PASS] test_wrsETHAdmin() (gas: 2190586) Ran 1 test suite in 54.66s (54.66s CPU time): 3 tests passed, 0 failed, 0 skipped (3 total tests) |
Ready for review