Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get PR information if unknown #8

Open
bgrainger opened this issue Sep 23, 2015 · 0 comments
Open

Get PR information if unknown #8

bgrainger opened this issue Sep 23, 2015 · 0 comments

Comments

@bgrainger
Copy link
Owner

If a webhook is missing on a repo when a PR is opened, there's no way to get that information to LPRB. Writing "rebuild this" or closing and reopening the PR will give the following error:

INFO: LPRB/91456 on host: Received build request for User/Repo/3.
INFO: LPRB/91456 on host: User/Repo/3 has includingPrs:
ERROR: LPRB/91456 on host: Cannot read property 'base' of undefined
    TypeError: Cannot read property 'base' of undefined
        at Object.getPrBuilds (/usr/local/src/leeroy-pull-request-builder/dist/state.js:75:27)
        at /usr/local/src/leeroy-pull-request-builder/dist/server.js:338:16
        at tryCatcher (/usr/local/src/leeroy-pull-request-builder/node_modules/rx/dist/rx.js:59:31)
        at InnerObserver.tryCatcher (/usr/local/src/leeroy-pull-request-builder/node_modules/rx/dist/rx.js:59:31)
        at AnonymousObserver._onCompleted (/usr/local/src/leeroy-pull-request-builder/node_modules/rx/dist/rx.aggregates.js:816:13)
    From previous event:
        at buildPullRequest (/usr/local/src/leeroy-pull-request-builder/dist/server.js:332:35)
        at AnonymousObserver._onNext (/usr/local/src/leeroy-pull-request-builder/dist/server.js:476:2)
        at AnonymousObserver.tryCatcher (/usr/local/src/leeroy-pull-request-builder/node_modules/rx/dist/rx.js:59:31)
    From previous event:
        at buildPullRequest (/usr/local/src/leeroy-pull-request-builder/dist/server.js:332:69)
        at AnonymousObserver._onNext (/usr/local/src/leeroy-pull-request-builder/dist/server.js:476:2)
        at AnonymousObserver.tryCatcher (/usr/local/src/leeroy-pull-request-builder/node_modules/rx/dist/rx.js:59:31)
    From previous event:
        at buildPullRequest (/usr/local/src/leeroy-pull-request-builder/dist/server.js:332:69)
        at AnonymousObserver._onNext (/usr/local/src/leeroy-pull-request-builder/dist/server.js:476:2)
        at AnonymousObserver.tryCatcher (/usr/local/src/leeroy-pull-request-builder/node_modules/rx/dist/rx.js:59:31)
    From previous event:
        at MergeAllObservable.observableProto.toSet (/usr/local/src/leeroy-pull-request-builder/node_modules/rx/dist/rx.aggregates.js:810:12)
        at buildPullRequest (/usr/local/src/leeroy-pull-request-builder/dist/server.js:334:5)
        at AnonymousObserver._onNext (/usr/local/src/leeroy-pull-request-builder/dist/server.js:476:2)
        at AnonymousObserver.tryCatcher (/usr/local/src/leeroy-pull-request-builder/node_modules/rx/dist/rx.js:59:31)
    From previous event:
        at buildPullRequest (/usr/local/src/leeroy-pull-request-builder/dist/server.js:337:36)
        at AnonymousObserver._onNext (/usr/local/src/leeroy-pull-request-builder/dist/server.js:476:2)
        at AnonymousObserver.tryCatcher (/usr/local/src/leeroy-pull-request-builder/node_modules/rx/dist/rx.js:59:31)

We need to check for "unknown" PRs and fetch them via the GitHub API before integrating them. This would allow someone to add the webhook and simply enter "rebuild this" in a PR comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant