Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript only #23

Open
ghost opened this issue Aug 9, 2020 · 6 comments
Open

Javascript only #23

ghost opened this issue Aug 9, 2020 · 6 comments

Comments

@ghost
Copy link

ghost commented Aug 9, 2020

This so-called 'gem' only works as advertised with Javascript.

Don't waste your time...

-- cc

@chuckmitchell
Copy link

Got any more details?

@ghost
Copy link
Author

ghost commented Oct 11, 2020

See: jwadhams/json-logic#24

-- cc

@bhgames
Copy link
Owner

bhgames commented May 4, 2021

You raise a good point. Would you like to make a PR to adjust the read me to say that we currently do not support the full json logic spec at this time? I don't personally have time right now to fully implement that missing functionality, but you're right, we shouldn't be claiming we have that functionality for adding methods when we do not. I inherited this, so I was not aware we did not support more than single-argument methods, and it's a valid point.

@ghost
Copy link
Author

ghost commented May 4, 2021

Sure... It's not going to be much though... I've really moved on from this and the project I was looking to use this on is done.

I don't do much at Github so I'll have to refresh my memory about the workflow here...and you'll have to excuse me if I violate any protocols you've established about it.

I don't understand Javascript enough to help with the code though.

-- cc

@ghost
Copy link
Author

ghost commented Jun 25, 2021

I submitted a pull-request for the doc changes you wanted on 5/4/2021. It remains un-merged. If you're not going to merge it, please tell me. I'd like to get rid of my fork.

-- cc

@bhgames
Copy link
Owner

bhgames commented Jun 25, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants