From 6ecd689bac3b54d5e80e8f6a25f39ec959d3b873 Mon Sep 17 00:00:00 2001 From: Baha Aiman Date: Fri, 31 May 2024 16:51:54 +0000 Subject: [PATCH] feat(bigtable): fixing vet failures --- bigtable/metrics_test.go | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/bigtable/metrics_test.go b/bigtable/metrics_test.go index 891b24f7d35c..3af2eea65ff6 100644 --- a/bigtable/metrics_test.go +++ b/bigtable/metrics_test.go @@ -32,17 +32,17 @@ import ( ) var ( - clusterId1 = "cluster-id-1" - clusterId2 = "cluster-id-2" - zoneId1 = "zone-id-1" + clusterID1 = "cluster-id-1" + clusterID2 = "cluster-id-2" + zoneID1 = "zone-id-1" testHeaders, _ = proto.Marshal(&btpb.ResponseParams{ - ClusterId: &clusterId1, - ZoneId: &zoneId1, + ClusterId: &clusterID1, + ZoneId: &zoneID1, }) testTrailers, _ = proto.Marshal(&btpb.ResponseParams{ - ClusterId: &clusterId2, - ZoneId: &zoneId1, + ClusterId: &clusterID2, + ZoneId: &zoneID1, }) testHeaderMD = &metadata.MD{ @@ -93,8 +93,8 @@ func TestToOtelMetricAttrs(t *testing.T) { attribute.String(metricLabelKeyMethod, "ReadRows"), attribute.Bool(metricLabelKeyStreamingOperation, true), attribute.String(metricLabelKeyOperationStatus, codes.OK.String()), - attribute.String(monitoredResLabelKeyCluster, clusterId1), - attribute.String(monitoredResLabelKeyZone, zoneId1), + attribute.String(monitoredResLabelKeyCluster, clusterID1), + attribute.String(monitoredResLabelKeyZone, zoneID1), }, wantError: nil, }, @@ -229,24 +229,24 @@ func TestGetLocation(t *testing.T) { desc: "Location metadata in header", headerMD: testHeaderMD, trailerMD: &metadata.MD{}, - wantCluster: clusterId1, - wantZone: zoneId1, + wantCluster: clusterID1, + wantZone: zoneID1, wantError: nil, }, { desc: "Location metadata in trailer", headerMD: &metadata.MD{}, trailerMD: testTrailerMD, - wantCluster: clusterId2, - wantZone: zoneId1, + wantCluster: clusterID2, + wantZone: zoneID1, wantError: nil, }, { desc: "Location metadata in both header and trailer", headerMD: testHeaderMD, trailerMD: testTrailerMD, - wantCluster: clusterId1, - wantZone: zoneId1, + wantCluster: clusterID1, + wantZone: zoneID1, wantError: nil, }, {