From ae152d460dec9abfc15e2e7d7d62f21c9d4783fa Mon Sep 17 00:00:00 2001 From: Yaroslav Halchenko Date: Fri, 19 Apr 2024 18:45:27 -0400 Subject: [PATCH] Use specific version of validator for now, and redid validation of examples, point to the schema correctly for running tests --- .github/workflows/validate_bids-examples.yml | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/validate_bids-examples.yml b/.github/workflows/validate_bids-examples.yml index 2a19f75bdf..3d685fbe76 100644 --- a/.github/workflows/validate_bids-examples.yml +++ b/.github/workflows/validate_bids-examples.yml @@ -57,8 +57,13 @@ jobs: if: "matrix.bids-validator == 'master-deno'" run: | pushd .. + # Let's use specific commit for now + # TODO: progress it once in a while + commit=a7b291b882a8c6184219ccb84faae255ba96203a git clone --depth 1 https://github.com/bids-standard/bids-validator - echo -e '#!/bin/sh\n'"$PWD/bids-validator/bids-validator/bids-validator-deno \"\$@\"" >| /usr/local/bin/bids-validator + cd bids-validator + git fetch --depth 1 origin $commit; + echo -e '#!/bin/sh\n'"$PWD/bids-validator/bids-validator-deno \"\$@\"" >| /usr/local/bin/bids-validator chmod a+x /usr/local/bin/bids-validator which -a bids-validator bids-validator --help @@ -84,7 +89,7 @@ jobs: path: bids-examples - name: Mark known not yet to be deno-legit BIDS datasets - run: touch {ds000117,ds000248,eeg_ds003645s_hed_demo,ieeg_epilepsy,ieeg_epilepsy_ecog,ieeg_epilepsyNWB,ieeg_visual_multimodal}/.SKIP_VALIDATION + run: touch {ds000117,ds000246,ds000247,ds000248,eeg_ds003645s_hed_demo,ieeg_motorMiller2007,ieeg_visual}/.SKIP_VALIDATION shell: bash working-directory: bids-examples @@ -102,5 +107,5 @@ jobs: working-directory: bids-examples - name: Validate all BIDS datasets using bids-validator after migration - run: VALIDATOR_ARGS="-s local" bash ./run_tests.sh + run: VALIDATOR_ARGS="--schema file://$PWD/../src/schema.json" bash ./run_tests.sh working-directory: bids-examples