Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink open–closed principle #2

Open
bigMOTOR opened this issue Jul 23, 2020 · 4 comments
Open

Rethink open–closed principle #2

bigMOTOR opened this issue Jul 23, 2020 · 4 comments
Assignees
@bigMOTOR
Labels
enhancement New feature or request

Comments

@bigMOTOR
Copy link
Owner

There is an old but still actual thread in RxDataSources about animation when animation style is none Nobody would like to fix it there but it bothers me and should be done.
@bigMOTOR bigMOTOR self-assigned this Jul 23, 2020
@bigMOTOR bigMOTOR added the bug Something isn't working label Jul 23, 2020
bigMOTOR added a commit that referenced this issue Jul 23, 2020
@bigMOTOR
Issue 2: Rx Animated Data Source still animates when animation style …
ea0c011 
…is set to none

#2
@bigMOTOR bigMOTOR mentioned this issue Jul 23, 2020
Closed
@bigMOTOR
Copy link
Owner Author

@mashe Hi! Could you take a look please? 😊

@bigMOTOR
Copy link
Owner Author

Rethink of the root cause of this and came up with the idea that our lib has issues with open/close classes. I mean it will be good to have a possibility to inject some different datasource (eg with UIKit animation fix) from the outside.

@bigMOTOR bigMOTOR changed the title Rx Animated Data Source still animates when animation style is set to none Rethink open–closed principle Jul 31, 2020
@bigMOTOR bigMOTOR added enhancement New feature or request and removed bug Something isn't working labels Jul 31, 2020
bigMOTOR added a commit that referenced this issue Oct 13, 2020
@bigMOTOR
Issue 2: Rx Animated Data Source still animates when animation style …
2bb6c23 
…is set to none

#2
@mashe
Copy link
Collaborator

mashe commented Aug 25, 2021

After implementing UITableViewDiffableDataSource support we made a small step in that direction I guess

@bigMOTOR
Copy link
Owner Author

@mashe Tiny I guess... 😊
But I really appreciate all your work with DiffableDataSource 🙌 It's awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigMOTOR bigMOTOR

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mashe @bigMOTOR