From 251db6a2046ff97e279634dc3f9d1f535fe318e7 Mon Sep 17 00:00:00 2001
From: Chengxin Dai <37200167+daichengxin@users.noreply.github.com>
Date: Wed, 18 Dec 2024 21:13:29 +0800
Subject: [PATCH 1/2] fixed bugs

---
 quantmsrescore/ms2rescore.py | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/quantmsrescore/ms2rescore.py b/quantmsrescore/ms2rescore.py
index 9d02c50..5251123 100644
--- a/quantmsrescore/ms2rescore.py
+++ b/quantmsrescore/ms2rescore.py
@@ -36,6 +36,7 @@ def __init__(self, filename: Union[Path, str], *args, **kwargs) -> None:
         self.user_params_metadata = self._get_userparams_metadata(self.peptide_ids[0].getHits()[0])
         self.rescoring_features = self._get_rescoring_features(self.peptide_ids[0].getHits()[0])
         self.skip_invalid_psm = 0
+        self.new_peptide_ids = []
 
     def __iter__(self) -> Iterable[PSM]:
         """
@@ -63,12 +64,16 @@ def __iter__(self) -> Iterable[PSM]:
 
         """
         for peptide_id in self.peptide_ids:
+            new_hits = []
             for peptide_hit in peptide_id.getHits():
                 psm = self._parse_psm(self.protein_ids, peptide_id, peptide_hit)
                 if psm is not None:
+                    new_hits.append(peptide_hit)
                     yield psm
                 else:
                     self.skip_invalid_psm += 1
+            peptide_id.setHits(new_hits)
+            self.new_peptide_ids.append(peptide_id)
 
     def _parse_psm(
             self,
@@ -239,12 +244,14 @@ def rescore_idxml(input_file, output_file, config) -> None:
         logging.warning(
             f"Removed {reader.skip_invalid_psm} PSMs without search engine features!"
         )
-
+        peptide_ids = reader.new_peptide_ids
+    else:
+        peptide_ids = reader.peptide_ids
     # Rescore
     rescore(config, psm_list)
 
     # Filter out PeptideHits within PeptideIdentification(s) that could not be processed by all feature generators
-    peptide_ids_filtered = filter_out_artifact_psms(psm_list, reader.peptide_ids)
+    peptide_ids_filtered = filter_out_artifact_psms(psm_list, peptide_ids)
 
     # Write
     writer = IdXMLWriter(output_file, reader.protein_ids, peptide_ids_filtered)

From 3a16a96cca13cda917ff3c074274adeb056b3c6c Mon Sep 17 00:00:00 2001
From: Chengxin Dai <37200167+daichengxin@users.noreply.github.com>
Date: Wed, 18 Dec 2024 21:13:48 +0800
Subject: [PATCH 2/2] Update __init__.py

---
 quantmsrescore/__init__.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/quantmsrescore/__init__.py b/quantmsrescore/__init__.py
index 3b93d0b..27fdca4 100644
--- a/quantmsrescore/__init__.py
+++ b/quantmsrescore/__init__.py
@@ -1 +1 @@
-__version__ = "0.0.2"
+__version__ = "0.0.3"