Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatefulTable + TableFigure cuts off focus filter button styles #605

Open
rtalvarez opened this issue Oct 6, 2021 · 1 comment
Open

Comments

@rtalvarez
Copy link
Member

Describe the bug
Using StatefulTable with filters (pill tabs) wrapped in a TableFigure cuts off parts of the focused styles for the filter buttons

To Reproduce
Steps to reproduce the behavior:
https://codesandbox.io/s/charming-kalam-x4kmb

Focus (click/unclick) any filter, notice the styles get cut off

Expected behavior
Styles are not cut off

Screenshots
Screen Shot 2021-10-06 at 10 18 37 AM

Desktop (please complete the following information, if applicable):
Reproduced on chrome Version 92.0.4515.159 (Official Build) (x86_64) on osx

Additional context
Did not dig too much into the issue, filing this bug just so I don't forget to do so later. I can 🔍 when I get a chance

@chanceaclark
Copy link
Contributor

My first response to this was to set a negative margin and the same positive amount of padding on the figure element, but that could potentially cause some page level overflows 🤔

It's been on our backlog to tackle better responsive styles/patterns for tables, maybe it's something we need to take another gander at. cc. @bigcommerce/product-design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants