Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow commas in SV input #147

Closed
holtgrewe opened this issue Oct 17, 2023 · 0 comments · Fixed by #157
Closed

Allow commas in SV input #147

holtgrewe opened this issue Oct 17, 2023 · 0 comments · Fixed by #157
Assignees
@gromdimon
Labels
enhancement New feature or request
Milestone
0.1.0

Comments

@holtgrewe
Copy link
Member

Is your feature request related to a problem? Please describe.
At the moment, integers have to be typed as is. This is complicated for long coordinates such as DEL:chr17:41176312:41277500 or chr17:41197708:T:G.

Describe the solution you'd like
For SPDI and SVs we should allow for commas in the coordinates. They should be ignored when parsing (replace(",", "")).

Describe alternatives you've considered
NA

Additional context

  • adjust regexes for matching appropriately
  • do not touch gene names
  • do not touch HGVS descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gromdimon gromdimon

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

feat: Add support for commas in numbers in search Queries (#147) bihealth/reev
2 participants
@holtgrewe @gromdimon