Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentification info is not stored properly #532

Open
gromdimon opened this issue Feb 19, 2024 · 1 comment
Open

Authentification info is not stored properly #532

gromdimon opened this issue Feb 19, 2024 · 1 comment
Labels
bug Something isn't working internal Some internal note python Pull requests that update Python code
Milestone

Comments

@gromdimon
Copy link
Contributor

gromdimon commented Feb 19, 2024

There are various problems with current authentification.

account_email field is not updated in db (table oauth_account)

Describe the bug
When user clicks verification link in the mail it follows this path:

  1. Link https://reev.cubi.bihealth.org/verify-email?token=xxx
  2. VerifyEmailView in frontend
  3. sendVerifyRequest in AuthCline api
  4. /internal/auth/verify endpoint in backend (refers to fastapi_users.get_verify_router(UserRead))
  5. idk what happens later, but the db value of account_email field is not updated (table oauth_account)

Expected behavior
The account_email field should be changed.

Additional context
FastAPI-users discussions:
fastapi-users/fastapi-users#1359
fastapi-users/fastapi-users#1360

@gromdimon gromdimon added the bug Something isn't working label Feb 19, 2024
@gromdimon
Copy link
Contributor Author

The related question to this issues should be raised as discussuion in fastapi-users as well

@gromdimon gromdimon added this to the 1.0.0 milestone Feb 21, 2024
@gromdimon gromdimon added internal Some internal note python Pull requests that update Python code labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal Some internal note python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

1 participant