diff --git a/CHANGELOG.rst b/CHANGELOG.rst index 72ba6c35..cffece7d 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -124,6 +124,7 @@ Removed - Project starring timeline event creation (#1294) - ``user_email_additional`` app setting (#874) - ``get_visible_projects()`` template tag (#1432) + - App setting value max length limit (#1443) v0.13.4 (2024-02-16) diff --git a/docs/source/major_changes.rst b/docs/source/major_changes.rst index 82682489..d6a10bb6 100644 --- a/docs/source/major_changes.rst +++ b/docs/source/major_changes.rst @@ -37,6 +37,7 @@ Release Highlights - Plugin API return data updates and deprecations - Rename timeline app models - Rename base test classes +- Remove app setting max length limit - Remove Python v3.8 support - Remove SAML SSO support diff --git a/projectroles/forms.py b/projectroles/forms.py index 89ad8666..deecc474 100644 --- a/projectroles/forms.py +++ b/projectroles/forms.py @@ -24,7 +24,6 @@ RemoteProject, SODAR_CONSTANTS, ROLE_RANKING, - APP_SETTING_VAL_MAXLENGTH, CAT_DELIMITER, CAT_DELIMITER_ERROR_MSG, ) @@ -474,7 +473,6 @@ def _set_app_setting_field(self, plugin_name, s_field, s_key, s_val): ) elif s_val['type'] == 'STRING': self.fields[s_field] = forms.CharField( - max_length=APP_SETTING_VAL_MAXLENGTH, widget=forms.TextInput(attrs=s_widget_attrs), **setting_kwargs ) diff --git a/projectroles/migrations/0032_alter_appsetting_value.py b/projectroles/migrations/0032_alter_appsetting_value.py new file mode 100644 index 00000000..455396cb --- /dev/null +++ b/projectroles/migrations/0032_alter_appsetting_value.py @@ -0,0 +1,20 @@ +# Generated by Django 4.2.13 on 2024-06-20 14:31 + +from django.db import migrations, models + + +class Migration(migrations.Migration): + + dependencies = [ + ("projectroles", "0031_remotesite_owner_modifiable"), + ] + + operations = [ + migrations.AlterField( + model_name="appsetting", + name="value", + field=models.CharField( + blank=True, help_text="Value of the setting", null=True + ), + ), + ] diff --git a/projectroles/models.py b/projectroles/models.py index 268842a2..1d7cd1ca 100644 --- a/projectroles/models.py +++ b/projectroles/models.py @@ -51,7 +51,6 @@ ('STRING', 'String'), ('JSON', 'Json'), ] -APP_SETTING_VAL_MAXLENGTH = 255 PROJECT_SEARCH_TYPES = ['project'] PROJECT_TAG_STARRED = 'STARRED' CAT_DELIMITER = ' / ' @@ -935,7 +934,6 @@ class AppSetting(models.Model): #: Value of the setting value = models.CharField( - max_length=APP_SETTING_VAL_MAXLENGTH, unique=False, null=True, blank=True, diff --git a/userprofile/forms.py b/userprofile/forms.py index 41ec6013..845fbf3c 100644 --- a/userprofile/forms.py +++ b/userprofile/forms.py @@ -15,7 +15,6 @@ from projectroles.models import ( SODARUserAdditionalEmail, SODAR_CONSTANTS, - APP_SETTING_VAL_MAXLENGTH, ADD_EMAIL_ALREADY_SET_MSG, ) from projectroles.plugins import get_active_plugins @@ -97,7 +96,6 @@ def __init__(self, *args, **kwargs): ) else: self.fields[s_field] = forms.CharField( - max_length=APP_SETTING_VAL_MAXLENGTH, widget=forms.TextInput(attrs=s_widget_attrs), **setting_kwargs, )