Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect URL routes for project create/update/archive views #1392

Closed
Tracked by #1389
mikkonie opened this issue Mar 19, 2024 · 1 comment · Fixed by #1423
Closed
Tracked by #1389

Incorrect URL routes for project create/update/archive views #1392

mikkonie opened this issue Mar 19, 2024 · 1 comment · Fixed by #1423
Assignees
Labels
app: projectroles Issue in the projectroles app bug Something isn't working
Milestone

Comments

@mikkonie
Copy link
Collaborator

mikkonie commented Mar 19, 2024

I noticed we have the following routes in projectroles.urls:

route='project/update/<uuid:project>'
route='project/create'
route='project/create/<uuid:project>'
route='project/archive/<uuid:project>'

This is wrong, as the project/ prefix is already provided by including the projectroles app URLs into the site URL config. This creates URLs with project/project/x. It seems we have had this bug in since v0.13.0 but I've missed it.

The project/ prefix should be dropped from these routes.

Since we use URL names in our code everywhere, this should not break anything (except for possible user bookmarks for the erroneous URLs).

@mikkonie mikkonie added bug Something isn't working app: projectroles Issue in the projectroles app labels Mar 19, 2024
@mikkonie mikkonie added this to the v1.0.0 milestone Mar 19, 2024
@gromdimon gromdimon linked a pull request Apr 29, 2024 that will close this issue
mikkonie pushed a commit that referenced this issue May 2, 2024
@mikkonie
Copy link
Collaborator Author

mikkonie commented May 2, 2024

Done by @gromdimon, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: projectroles Issue in the projectroles app bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants