-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppLinkContent.get_user_links() generates errors in UI tests #1413
Labels
Milestone
Comments
mikkonie
added
bug
Something isn't working
app: projectroles
Issue in the projectroles app
labels
Apr 15, 2024
mikkonie
added a commit
that referenced
this issue
Apr 15, 2024
Example dump:
|
I fixed this myself as the test error dumps were making development quite difficult. The root cause is still not clear though, I'm not sure why the |
mikkonie
added a commit
that referenced
this issue
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Dump of error below. This didn't happen before the refactoring in #1381, so something must have gone through there.
Note that the tests still pass, we just get an absolute mountain of error messages. They can also be witnessed in CI e.g. here.
It seems we get a crash when trying to determine
resolver_match
when it's not in the request:The method should gracefully check whether the resolver info is included in the request. If not, it should just skip the app highlighting.
I think before this was done in the Django template so it just failed silently.
The text was updated successfully, but these errors were encountered: