Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project sidebar and dropdown display links in incorrect order #1468

Closed
mikkonie opened this issue Aug 9, 2024 · 1 comment
Closed

Project sidebar and dropdown display links in incorrect order #1468

mikkonie opened this issue Aug 9, 2024 · 1 comment
Assignees
@mikkonie
Labels
app: projectroles Issue in the projectroles app bug Something isn't working
Milestone
v1.0.2

Comments

@mikkonie
Copy link
Collaborator

mikkonie commented Aug 9, 2024

A bug I only discovered when doing bihealth/sodar-server#1922. In SODAR, the landingzones and samplesheets app links are reversed. It seems plugin_ordering is not taken into consideration at all?

I believe in get_project_app_links(), get_active_plugins() should be called with custom_order=True.
@mikkonie mikkonie added bug Something isn't working app: projectroles Issue in the projectroles app labels Aug 9, 2024
@mikkonie mikkonie added this to the v1.0.2 milestone Aug 9, 2024
@mikkonie mikkonie self-assigned this Aug 9, 2024
mikkonie added a commit that referenced this issue Aug 9, 2024
@mikkonie
fix get_project_app_links() plugin link order (#1468)
7174f62
@mikkonie
Copy link
Collaborator Author

mikkonie commented Aug 9, 2024

Fixed.

@mikkonie mikkonie closed this as completed Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: projectroles Issue in the projectroles app bug Something isn't working
Projects
None yet
Milestone
v1.0.2
Development

No branches or pull requests
1 participant
@mikkonie