Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move get_user_display_name() into SODARUser model, deprecate #1487

Open
mikkonie opened this issue Sep 5, 2024 · 0 comments
Open

Move get_user_display_name() into SODARUser model, deprecate #1487

mikkonie opened this issue Sep 5, 2024 · 0 comments
Labels
app: projectroles Issue in the projectroles app feature Requested feature or enhancement
Milestone

Comments

@mikkonie
Copy link
Collaborator

mikkonie commented Sep 5, 2024

Another case of an unneceessary utility method. This can go in the model. However, this is a breaking change as other sites may be using the method. Also, the implementation should be improved

Tasks

  • Move get_user_display_name() into SODARUser.get_display_name()
  • Improve implementation to use SODARUser.get_full_name() instead of name
  • Deprecate get_user_display_name() with a warning
@mikkonie mikkonie added internal Changes invisible to the user or APIs (e.g. refactoring and optimization) app: projectroles Issue in the projectroles app labels Sep 5, 2024
@mikkonie mikkonie added this to the v1.0.2 milestone Sep 5, 2024
@mikkonie mikkonie self-assigned this Sep 5, 2024
@mikkonie mikkonie changed the title Move get_user_display_name() into SODARUser model Move get_user_display_name() into SODARUser model, deprecate Sep 5, 2024
@mikkonie mikkonie removed their assignment Sep 5, 2024
@mikkonie mikkonie added feature Requested feature or enhancement and removed internal Changes invisible to the user or APIs (e.g. refactoring and optimization) labels Sep 5, 2024
@mikkonie mikkonie modified the milestones: v1.0.2, v1.1.0 Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: projectroles Issue in the projectroles app feature Requested feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant