Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auth type to SODARUserSerializer #1501

Open
mikkonie opened this issue Oct 10, 2024 · 0 comments
Open

Add auth type to SODARUserSerializer #1501

mikkonie opened this issue Oct 10, 2024 · 0 comments
Assignees
@mikkonie
Labels
app: projectroles Issue in the projectroles app feature Requested feature or enhancement
Milestone
v1.1.0

Comments

@mikkonie
Copy link
Collaborator

mikkonie commented Oct 10, 2024 •
edited
Loading

Similar to #1500, this information should be added to whereever we list user details in the REST API.

This is not a breaking change, but I don't want to do API changes in ..1 releases unless absolutely necessary. Hence I'm tagging this for v1.1.

Technically this should be done so that the value is only requested if the projectroles API is called with the 1.1 version.

Q: The User serializer is also used by other APIs. Should their version numbers also be bumped up? And if so, how to limit the returning of the newly added field if they are called with version 1.0?
@mikkonie mikkonie added feature Requested feature or enhancement app: projectroles Issue in the projectroles app labels Oct 10, 2024
@mikkonie mikkonie added this to the v1.1.0 milestone Oct 10, 2024
@mikkonie mikkonie self-assigned this Oct 10, 2024
@mikkonie mikkonie changed the title Add auth type to SODARUser REST API serializer Add auth type to SODARUserSerializer Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: projectroles Issue in the projectroles app feature Requested feature or enhancement
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@mikkonie