Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update REST API versioning for SODAR Core v1.0 #1936

Closed
5 of 7 tasks
mikkonie opened this issue Mar 26, 2024 · 1 comment
Closed
5 of 7 tasks

Update REST API versioning for SODAR Core v1.0 #1936

mikkonie opened this issue Mar 26, 2024 · 1 comment
Assignees
@mikkonie
Labels
app: irodsinfo Issue in the irodsinfo app app: landingzones Issue in the landingzones app app: samplesheets Issue in the samplesheets app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement
Milestone
v1.0.0

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Mar 26, 2024 •
edited
Loading

To be done after/during #1922.

REST API versioning will be changed in SODAR Core v1.0.0, see bihealth/sodar-core#1278.

These changes need to be also done for SODAR apps. This will sadly be a breaking change, as deprecating the old versioning and providing a temporary workaround would IMHO not be worth the effort.

API calls without strict versioning will continue to work as usual, as URLs are not affected. My hunch is that most clients haven't even bothered to set up versioning, but I could be wrong..

Tasks
@mikkonie mikkonie added breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement app: samplesheets Issue in the samplesheets app app: landingzones Issue in the landingzones app app: irodsinfo Issue in the irodsinfo app labels Mar 26, 2024
@mikkonie mikkonie added this to the v1.0.0 milestone Mar 26, 2024
@mikkonie mikkonie self-assigned this Mar 26, 2024
@mikkonie mikkonie mentioned this issue Aug 7, 2024
Closed
37 tasks
mikkonie added a commit that referenced this issue Sep 10, 2024
@mikkonie
update samplesheets api versioning (#1936)
eb0753b
mikkonie added a commit that referenced this issue Sep 10, 2024
@mikkonie
update landingzones api versioning (#1936)
b83f071
mikkonie added a commit that referenced this issue Sep 10, 2024
@mikkonie
fix permission tests (#1936)
3b3d511
mikkonie added a commit that referenced this issue Sep 10, 2024
@mikkonie
update irodsinfo api versioning (#1936)
875e102
mikkonie added a commit that referenced this issue Sep 10, 2024
@mikkonie
update settings (#1936)
200e6fc
mikkonie added a commit that referenced this issue Sep 10, 2024
@mikkonie
fix settings (#1936)
19866a8
mikkonie added a commit that referenced this issue Sep 10, 2024
@mikkonie
update rest api versioning (#1936)
185955a
@mikkonie
Copy link
Contributor Author

Done.

This was referenced Sep 10, 2024
Closed
Open
mikkonie added a commit that referenced this issue Sep 12, 2024
@mikkonie
update rest api versioning (#1936)
71adb59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkonie mikkonie

Labels
app: irodsinfo Issue in the irodsinfo app app: landingzones Issue in the landingzones app app: samplesheets Issue in the samplesheets app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@mikkonie