Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project for OpenAPI compatibility #1951

Closed
mikkonie opened this issue Jun 21, 2024 · 2 comments
Closed

Update project for OpenAPI compatibility #1951

mikkonie opened this issue Jun 21, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation environment Issues of dependencies, CI, deployment etc. feature Requested feature or enhancement
Milestone

Comments

@mikkonie
Copy link
Contributor

Once upgrading to SODAR Core v1.0 in #1922, we should also ensure OpenAPI compatibility. Most likely there are some errors and warnings similar to what we encountered in e.g. bihealth/sodar-core#1440 and bihealth/sodar-core#1442. Also dependencies need to be updated, see bihealth/sodar-core#1444.

@mikkonie mikkonie added the environment Issues of dependencies, CI, deployment etc. label Jun 21, 2024
@mikkonie mikkonie added this to the v1.0.0 milestone Jun 21, 2024
@mikkonie mikkonie self-assigned this Jun 21, 2024
@mikkonie mikkonie added feature Requested feature or enhancement documentation Improvements or additions to documentation labels Sep 11, 2024
@mikkonie
Copy link
Contributor Author

After fixing the get_serializer_context() implementations requiring a request object, the following warnings remain:

/home/mikkopen/.virtualenvs/sodar1.0/lib/python3.11/site-packages/rest_framework/schemas/openapi.py:48: UserWarning: You have a duplicated operationId in your OpenAPI schema: retrieveLandingZone
	Route: /landingzones/api/list/{project}, Method: get
	Route: /landingzones/api/retrieve/{landingzone}, Method: get
	An operationId has to be unique across your schema. Your schema may not work in other tools.
  warnings.warn(
/home/mikkopen/.virtualenvs/sodar1.0/lib/python3.11/site-packages/rest_framework/schemas/openapi.py:48: UserWarning: You have a duplicated operationId in your OpenAPI schema: retrieveIrodsAccessTicket
	Route: /samplesheets/api/irods/ticket/list/{project}, Method: get
	Route: /samplesheets/api/irods/ticket/retrieve/{irodsaccessticket}, Method: get
	An operationId has to be unique across your schema. Your schema may not work in other tools.
  warnings.warn(
/home/mikkopen/.virtualenvs/sodar1.0/lib/python3.11/site-packages/rest_framework/schemas/openapi.py:48: UserWarning: You have a duplicated operationId in your OpenAPI schema: retrieveIrodsDataRequest
	Route: /samplesheets/api/irods/request/retrieve/{irodsdatarequest}, Method: get
	Route: /samplesheets/api/irods/requests/{project}, Method: get
	An operationId has to be unique across your schema. Your schema may not work in other tools.
  warnings.warn(
/home/mikkopen/.virtualenvs/sodar1.0/lib/python3.11/site-packages/rest_framework/schemas/openapi.py:48: UserWarning: You have a duplicated operationId in your OpenAPI schema: retrieveSheetISAExport
	Route: /samplesheets/api/export/zip/{project}, Method: get
	Route: /samplesheets/api/export/json/{project}, Method: get
	An operationId has to be unique across your schema. Your schema may not work in other tools.
  warnings.warn(
/home/mikkopen/.virtualenvs/sodar1.0/lib/python3.11/site-packages/rest_framework/schemas/openapi.py:48: UserWarning: You have a duplicated operationId in your OpenAPI schema: createZoneSubmitMove
	Route: /landingzones/api/submit/validate/{landingzone}, Method: post
	Route: /landingzones/api/submit/move/{landingzone}, Method: post
	An operationId has to be unique across your schema. Your schema may not work in other tools.
  warnings.warn(

@mikkonie
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation environment Issues of dependencies, CI, deployment etc. feature Requested feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant