Warning msg when you try to create more than 10 favorite labels

[dlangenk]

When you try to create the 11th favorite label it will not be favorited, which is as expected, but having a warning message shown would be nice.

[mzur]

What do you think about hiding the star button for all labels except the favourite labels in this case? I thought this was already the case but either this was part of a regression at some point or it never was like this.

[dlangenk]

I have mixed feelings about hiding the star. It is better than the current version, but it is a little bit like the "missing" pin button. It might not be intuitive to the user that you cannot favorite more then 10 labels, or pin more than 3 projects.

[mzur]

Then show the star in a "disabled" visual state and add a title (popup) text explaining why no more favourites can be added?

[dlangenk]

That sounds great. What do you think, should we show the popup after 10 favorites have been set or if you try to click a disabled star? How does this interfere with #957?

[mzur]

The popup is shown if 10 favourites were set and the mouse hovers over the (disabled) star. With #957 users can add more than 10 favourites. When they add the 11th label, a new (empty) label preset could be started (if there is any). The UI must make this clear with animations, highlighting etc.