Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache to texture broken for Allegro 5 #27

Open
okonk opened this issue Aug 2, 2016 · 3 comments
Open

Cache to texture broken for Allegro 5 #27

okonk opened this issue Aug 2, 2016 · 3 comments
Labels
bug

Comments

@okonk
Copy link
Contributor

okonk commented Aug 2, 2016

The ColorPicker sample for Allegro5 is broken.

I don't need to use this control, just thought you might want to know.

gwork_sample
@billyquith
Copy link
Owner

Thanks. I bet it is the render caching.

@billyquith billyquith changed the title ColorPicker doesn't work in GworkAllegro5Sample Cache to texture broken for Allegro 5 Aug 2, 2016
billyquith added a commit that referenced this issue Aug 2, 2016
@billyquith
Disable use of CTT for color picker.
82994b3 
- Address issue #27.
- Temporarily disable cache to texture. Broken with Allegro 5.2.
@billyquith billyquith added the bug label Aug 2, 2016
@billyquith
Copy link
Owner

Cache to texture is broken. A texture is created and cleared (rendered to), but then controls are not drawn to the texture, and possible drawn in the wrong location. Odd, as appears to work for the properties test, but not standalone, so possibly something to with clipping or bounds calculation.

billyquith added a commit that referenced this issue Aug 14, 2016
@billyquith
Merge branch 'gwork' into ponder
d704862 
* gwork: (54 commits)
  Use for-range
  Store and restore OpenGL states whilst rendering - Thanks to @lonestarr - garrynewman/GWEN#59
  Tidy.
  Specific directory for SFML2 resource loading - Use directory relative to application executable. - Fixes issue #29 - Fix app resource copy for non-bundled apps.
  Add editor config.
  Use cmake file properties to set bundle resources for OSX.
  Replace deprecated method - SFML2.4 setColor deprecated
  Tidy.
  If tall menu descends off screen then clamp to screen height - Thanks to @qehgt - garrynewman/GWEN@c8aacf8
  Include correct dialog header. - Thanks to @kklouzal - garrynewman/GWEN#95
  Correct spelling of caret. - Thanks to @kklouzal garrynewman/GWEN#93
  comment cannot be on same line.
  Disable use of CTT for color picker. - Address issue #27. - Temporarily disable cache to texture. Broken with Allegro 5.2.
  cmake: Make MacOS package - This fixes hi-res screen for Allegro5. See Allegro5 notes on building apps for OSX. Use C++11 def to build C++11.
  Add <cctype> header for std::isprint
  Changes to get GWork to compile on Windows/VS2015
  Use DebugBreak to break into debugger - cross platform debug break to fix issue #25
  - Correct readme - simplify gitignore
  - Output bin/lib to root. - cmake -D doesn't like spaces - Readme: use Allegro 5 instead of SDL2 as clipping bug not fixed
  Clarify origin of std::isprint
  ...

# Conflicts:
#	cmake/Modules/FindAllegro5.cmake
#	cmgen.sh
#	source/gwork/include/Gwork/Skins/Simple.h
#	source/gwork/include/Gwork/Skins/TexturedBase.h
#	source/gwork/source/Events.cpp
#	source/platform/renderers/Allegro5/Allegro5.cpp
#	source/platform/renderers/Direct2D/Direct2D.cpp
#	source/platform/renderers/DirectX9/DirectX9.cpp
#	source/platform/renderers/GDIPlus/GDIPlus.cpp
#	source/platform/renderers/OpenGL/OpenGL.cpp
#	source/samples/Allegro5/Allegro5Sample.cpp
#	source/test/source/api/Button.cpp
billyquith added a commit that referenced this issue Aug 1, 2017
@billyquith
Merge branch 'gwork' into ponder
b6bc245 
* gwork: (54 commits)
  Use for-range
  Store and restore OpenGL states whilst rendering - Thanks to @lonestarr - garrynewman/GWEN#59
  Tidy.
  Specific directory for SFML2 resource loading - Use directory relative to application executable. - Fixes issue #29 - Fix app resource copy for non-bundled apps.
  Add editor config.
  Use cmake file properties to set bundle resources for OSX.
  Replace deprecated method - SFML2.4 setColor deprecated
  Tidy.
  If tall menu descends off screen then clamp to screen height - Thanks to @qehgt - garrynewman/GWEN@c8aacf8
  Include correct dialog header. - Thanks to @kklouzal - garrynewman/GWEN#95
  Correct spelling of caret. - Thanks to @kklouzal garrynewman/GWEN#93
  comment cannot be on same line.
  Disable use of CTT for color picker. - Address issue #27. - Temporarily disable cache to texture. Broken with Allegro 5.2.
  cmake: Make MacOS package - This fixes hi-res screen for Allegro5. See Allegro5 notes on building apps for OSX. Use C++11 def to build C++11.
  Add <cctype> header for std::isprint
  Changes to get GWork to compile on Windows/VS2015
  Use DebugBreak to break into debugger - cross platform debug break to fix issue #25
  - Correct readme - simplify gitignore
  - Output bin/lib to root. - cmake -D doesn't like spaces - Readme: use Allegro 5 instead of SDL2 as clipping bug not fixed
  Clarify origin of std::isprint
  ...

# Conflicts:
#	cmake/Modules/FindAllegro5.cmake
#	cmgen.sh
#	source/gwork/include/Gwork/Skins/Simple.h
#	source/gwork/include/Gwork/Skins/TexturedBase.h
#	source/gwork/source/Events.cpp
#	source/platform/renderers/Allegro5/Allegro5.cpp
#	source/platform/renderers/Direct2D/Direct2D.cpp
#	source/platform/renderers/DirectX9/DirectX9.cpp
#	source/platform/renderers/GDIPlus/GDIPlus.cpp
#	source/platform/renderers/OpenGL/OpenGL.cpp
#	source/samples/Allegro5/Allegro5Sample.cpp
#	source/test/source/api/Button.cpp
@billyquith
Copy link
Owner

Perhaps this would be better solved as a general render target texture, which might be used for other things.

This was referenced Jan 10, 2018
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@okonk @billyquith