From d0581c69231c471f347ef103918a14fbf7491d97 Mon Sep 17 00:00:00 2001
From: GAETAN LAGIER <gaetan@bimdata.io>
Date: Tue, 2 Apr 2024 17:00:09 +0200
Subject: [PATCH] remove circular dependency in BIMDataTree

---
 src/BIMDataComponents/BIMDataTree/Node.vue    | 34 ++++++++++++++++--
 .../BIMDataTree/NodeChildren.js               | 35 -------------------
 2 files changed, 32 insertions(+), 37 deletions(-)
 delete mode 100644 src/BIMDataComponents/BIMDataTree/NodeChildren.js

diff --git a/src/BIMDataComponents/BIMDataTree/Node.vue b/src/BIMDataComponents/BIMDataTree/Node.vue
index 6c9c65c4..b7001f57 100644
--- a/src/BIMDataComponents/BIMDataTree/Node.vue
+++ b/src/BIMDataComponents/BIMDataTree/Node.vue
@@ -48,9 +48,39 @@
 </template>
 
 <script>
-import { inject, ref, computed, watch, isRef } from "vue";
+import { inject, ref, computed, watch, isRef, h } from "vue";
 
-import NodeChildren from "./NodeChildren.js";
+const NodeChildren = {
+  inject: ["root"],
+  props: {
+    node: {
+      type: Object,
+      required: true,
+      validator: node => Number.isFinite(node?.id),
+    },
+    depth: {
+      type: Number,
+      default: 0,
+    },
+  },
+  render() {
+    const { node, depth, root } = this;
+
+    const state = root.state;
+
+    return node.children.map(child =>
+      h(Node, { node: child, depth, key: child.id }, () =>
+        root.$slots.node?.({
+          node: child,
+          depth,
+          selected: child.id === state.selectedId,
+          hovered: child.id === state.hoveredNode?.id,
+          ancestorSelected: state.hasAncestorSelected(child),
+        })
+      )
+    );
+  },
+};
 
 export default {
   name: "Node",
diff --git a/src/BIMDataComponents/BIMDataTree/NodeChildren.js b/src/BIMDataComponents/BIMDataTree/NodeChildren.js
deleted file mode 100644
index 919d3db4..00000000
--- a/src/BIMDataComponents/BIMDataTree/NodeChildren.js
+++ /dev/null
@@ -1,35 +0,0 @@
-import { h } from "vue";
-
-import Node from "./Node.vue";
-
-export default {
-  inject: ["root"],
-  props: {
-    node: {
-      type: Object,
-      required: true,
-      validator: node => Number.isFinite(node?.id),
-    },
-    depth: {
-      type: Number,
-      default: 0,
-    },
-  },
-  render() {
-    const { node, depth, root } = this;
-
-    const state = root.state;
-
-    return node.children.map(child =>
-      h(Node, { node: child, depth, key: child.id }, () =>
-        root.$slots.node?.({
-          node: child,
-          depth,
-          selected: child.id === state.selectedId,
-          hovered: child.id === state.hoveredNode?.id,
-          ancestorSelected: state.hasAncestorSelected(child),
-        })
-      )
-    );
-  },
-};