Nora's comments

[norakearns]

Hi Thai!

First of all, seriously amazing job!! Your code is super detailed and I think your dictionary approach is really efficient. Your functions make sense for your approach and this program would definitely accomplish the objective of the deduper assignment.

The only "critique" I have is not even really a critique, but I think that the second half of your code, where you actually check for duplicates, is a bit unclear/hard to follow. Specifically this:

  - Else:
                    - If chromosome_name == current_chrom_in_dict:
                        - add read to dict (temp_read[key] = line_tokens)

I couldn't tell what the function of current_chrom_in_dict was, or how this helped identify duplicates. Your pseudocode is super detailed but maybe a bit more "natural language" would have been helpful in understanding your approach - but that said, it obviously makes sense to you which is ultimately who this outline is for!

Happy deduping :)
Nora Kearns