deleteSample bug #616
Assignees
Labels
Comments
wasade
added a commit
to wasade/american-gut-web
that referenced
this issue
Sep 13, 2016
antgonza
pushed a commit
that referenced
this issue
Mar 30, 2017
* TST: test for #616 * BUG: fixed, checking if travis test env differs from local * Fix broken rollback decorator * fixing errors * fixing flake8 * escape urls * sty and failure * made the template more flexible, i.e. can now deal with unlimited numbers of surveys (external or internal). Updated the design slightly for a better overview. * bugfix: no primary survey for animal crashed the script. extension: made it more general to cope with unlimited numbers of surveys * added a new function to retrive all survey_ids for one ag_login_id+participant name with speaking names for the surveys * for better integration, links to vioscreen now look like buttons. * removed unused variables * code style issues * similar to the primary survey, a participant can now directly navigate to an earlier started secondary survey (surfer, fermented food) and edit his/her answers. * corrected phone number of Rob and HRPP Rob's wrong number: 858-246-1194 now 858-246-1184 HRPP's wrong number: 858-657-5100 now 858-246-7444 * fixed false assumption that a participant (source) has only one survey_id, when deleting this participant. * Adding the labadmin user tables * changed to tuple style SQL * fixed a typo * another stupid typo * Adding scrub script * Addressing @wasade's comments * Add missing birth years * Fix display order * Speeding up the scrubbing process * Fixing password value * added Jose's scrupped database * a new db function to obtain supplied_kit_id for a given ag_login_id * absolute kit_ids are now made relative in all unit tests by using the DB stable ag_login_id * a new function to obtain a kit_id from ag_handout_kits with 6 swaps and being printed. Needed for unittesting. * removing the last tst_ artifacts in tests * new helper functions to make unit tests general * a lot of adaptations for unit tests such that they work across DB versions * removed maxdiff=None * changed to a survey present in both DB versions restricted comparison to fields not scrubbed in both DB versions * dynamically fetching an unverified kit ID * obtain names from database, since they are scrubbed, before comparing to rendered HTML page * more helper functions for unit testing * modified tests to make them stable across DB changes * providing more documentation * refactoring method get_participant_names_from_ag_login_id * removed left over helper function * completed docu * removed DB dump * reset patch number * pep8 issues * pep8 issues * pep8 * debugging Survey * additional restruction to only those questions that belong to the right group * for debugging * don't rely on DB content any more, create it ourselves * undo changes to survey.py and moved it into its own PR * moved DB insertion into separat function * response to review comments * iterate over the elements of a set * small changes to address Jose's comments * Update scrub (#645) * Setting labadmin test user back to 'test' * Adding file with scrubbed columns * Addressing @sjanssen2's comments * Updating to latest dump * Fixing tests * Flake8ing * Updating scrub * Reverting change * Fixing typo * enforcing usage of tornado 4.4.2 instead of 3.2.2 * Lowering the emails * Renaming patch to avoid merge conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On call to
deleteAGParticipantSurvey, if sample is associated with the survey, a malformed call is made todeleteSamplein whichag_login_idis omitted.The text was updated successfully, but these errors were encountered: