bug: selection of question

[sjanssen2]

Is this a bug in amgut/lib/data_access/survey.py def fetch_survey()?
We might need to restrict the returned questions to the correct group they belong to:

•        sql = """SELECT survey_question_id, {1}.display_index,
                         survey_response_type
                         survey_response_type
                  FROM {0}
                  FROM {0}
                  JOIN {1} USING (response, survey_question_id)
                  JOIN {1} USING (response, survey_question_id)
                  JOIN {2} USING (survey_question_id)
                  JOIN {2} USING (survey_question_id)
                  LEFT JOIN {3} USING (survey_question_id)
                  LEFT JOIN {3} USING (survey_question_id)
  

•                 WHERE survey_id = %s AND retired = FALSE""".format(
  

•                 JOIN ag.group_questions USING (survey_question_id)
  

•                 WHERE survey_group = {4}
  

•                 AND survey_id = %s
  

•                 AND retired = FALSE""".format(
             self._survey_answers_table,
             self._survey_answers_table,
             self._survey_question_response_table,
             self._survey_question_response_table,
             self._survey_question_response_type_table,
             self._survey_question_response_type_table,
  

•            self._questions_table)
  

•            self._questions_table,
  

•            str(-1*self.id))
  

[sjanssen2]

I think I found a bug in amgut/lib/data_access/survey.py function fetch_survey():
I added the restriction that only those answers should be enumerated, that belong to the correct "survey_group". Tests are passing, but since our coverage is low I'd like you to ask to run some manual inspections.

[wasade]

I'm not sure I totally understand, can you elaborate a little more please?