Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8 participant names #649

Open
sjanssen2 opened this issue Mar 29, 2017 · 3 comments
Open

utf8 participant names #649

sjanssen2 opened this issue Mar 29, 2017 · 3 comments

Comments

@sjanssen2
Copy link
Contributor

If you log in as kit fdn_wsjdr, hover over "human samples" and the single participant and then try to click on the name, the sample overview is not shown. I figure it is because of UTF-8 issues in the generated HTML page.
Is it possible to do an escaping within the templates, here sitebase.html?
ag_data.get_menu_items(skid) retrieves unescaped strings directly from the database :-/

@wasade
Copy link
Member

wasade commented Mar 29, 2017

I'm starting to wonder whether we should just go to python3...? Might alleviate a lot of this pain.

@sjanssen2
Copy link
Contributor Author

Upgrading to Python3 would be so great - but as with the new DB version, I bet it will uncover a lot of additional bugs :-/

@josenavas
Copy link
Member

In this case, the problems are not the utf8 characters, but the \ and ' special characters that are breaking the JavaScript. When filling the tornado templates, these characters are not properly escaped, which break the JavaScript and hence some of the functionality. We have not found a good way of fixing this globally (including on Qiita) and we have been solving it in a case by case basis (ugh).

However, I do agree that moving to py3 would be great - do you want to organize another sprint after the current one is done to do the upgrade?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants