Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate instrument model in sample sheet and run outputs #4

Open
ElDeveloper opened this issue Feb 29, 2020 · 3 comments
Open

Validate instrument model in sample sheet and run outputs #4

ElDeveloper opened this issue Feb 29, 2020 · 3 comments

Comments

@ElDeveloper
Copy link
Member

As part of the pipeline, it would be beneficial to check that the instrument model in the sample sheet matches the instrument code in the run's folder name. If this is not the case, then we should raise an error as it could imply barcodes in the wrong orientation, or a different problem.

@charles-cowart
Copy link
Collaborator

I don't see an instrument model in the current sample-sheets, and I'm not sure which part of a run_directory's format (e.g. 211021_A00000_0000_SAMPLE) is the instrument code. I'm going to add MacKenzie to this project and confirm with her whether this is needed or not.

@charles-cowart
Copy link
Collaborator

@mmbryant23 Do you have any thoughts on the SPP having such a check?

@mmbryant23
Copy link

@charles-cowart I don't think this has been a pressing issue, especially because if barcodes were in the incorrect orientation, it would be very obvious post-processing (and this would be one of the first things to check for troubleshooting). Additionally, the iSeq/NovaSeq samplesheet generation steps have been further optimized in the notebook since this issue was originally opened, overall minimizing potential user error for generating the wrong type of samplesheet. If it was a straightforward check it wouldn't be a harmful check to have, but I think trying to figure out how to make this happen might take more effort than what it is worth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants