Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show tooltip with full text if text is truncated #1066

Closed
ripcurlx opened this issue Dec 6, 2017 · 11 comments
Closed

Always show tooltip with full text if text is truncated #1066

ripcurlx opened this issue Dec 6, 2017 · 11 comments
Assignees

Comments

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 6, 2017

To improve usability for languages which don't have a compact way of expression (e.g. French) truncated text should automatically cause an Tooltip to be shown on Rollover with the full text.

@ghost
Copy link

ghost commented Dec 6, 2017

OMG, I tried exactly to fix this problem on the last week on my own project and didn't find any simple straightforward solution similar to this one with textedit promptext, also was introduced by me some time ago ;)

@ManfredKarrer
Copy link
Member

Maybe with overriding the handling of the ellipsisString it could work? E.g. we use our extended version of Label/TextField and when usually the ellipsisString is shown we adjust the behavior to show a tooltip. Have not looked into it if it is feasible...

@ghost
Copy link

ghost commented Dec 6, 2017

I am always tried to solve such problems without need to extend JavaFX standard components, with this step it became possible - there are some receipts on StackOverflow, but more fragile and more difficult to support.

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Dec 6, 2017

Yes, I also think it won't be a nice solution, but I could also live with a hack, if everyone can read what we have to say in any language ;-)

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Dec 6, 2017

Actually, if find it kind of strange that this is not supported out-of-the-box by javafx.

@ManfredKarrer
Copy link
Member

Yes thats a weak part of JavaFX. Flash/Flex had that even >10 years ago...

@ripcurlx
Copy link
Contributor Author

Will be released as soon as UI-improvement branch goes live

@cbeams
Copy link
Member

cbeams commented Jan 16, 2018

Hey @ripcurlx, please don't close issues like this until code is actually on master. We never know what's going to happen, the UI-improvements branch might not get merged, there might be a delay, etc. Like I just mentioned in #1092 (comment), it's better to have a tracking issue like this that keeps us aware that work is not finished until code is on master and ready to ship in the next release.

@cbeams
Copy link
Member

cbeams commented Jan 16, 2018

This sort of thing, by the way, is part of the reason for the plan to do away with all feature/topic branches in the bisq-network/exchange repository (#1190) . Can discuss more fully elsewhere.

@ripcurlx
Copy link
Contributor Author

ok - will keep it that way with all other issues.

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Dec 4, 2018

Closing as complete.

@ripcurlx ripcurlx closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants