Limit the local port range the onion service can bind to

[nyxnor]

Thanks to @alvasw and the Bisq2 team, it v2.1.0 is working on Whonix 17.

Limiting port range the onion service can bind to locally. This is specially useful when using Whonix.

Currently, it recommends to open all ports in the firewall of the Workstation to be externally reachable via EXTERNAL_OPEN_ALL=true. That is not great.

It would be better to use the same method OnionShare uses, port ranges and tries different ones till it finds an unused port, which would be a better firewall with EXTERNAL_OPEN_PORTS+=" $(seq 17600 17659) ", with appropriate changes to the onion-grater profile (onion share example).

In other words, limit the localPort of:

bisq2/network/tor/tor/src/main/java/bisq/tor/controller/TorControlProtocol.java

Line 87 in 283bcff

String command = "ADD_ONION " + "ED25519-V3:" + base64SecretScalar + " Port=" + onionPort + "," + localPort + "\r\n";

to a range of possible ports and document it, so Whonix users can stay with a tight firewa...